1885363 - Merge ModuleEnvironment and Metadata

Status: RESOLVED DUPLICATE of bug 1891182

(Core :: JavaScript: WebAssembly, task, P3)

Description

[Ryan Hunt [:rhunt]]

ModuleEnvironment stores all the metadata needed to validate a module and compile it's functions. Metadata stores all the generic metadata needed by a running instance. The original design was that we could drop any metadata that's not needed at runtime when we move from a ModuleEnvironment to a Metadata object. However, overtime they've almost gotten to the point where they store exactly the same thing. At this point, the only difference appears to be that ModuleEnvironment stores FuncDesc's for all funcs in the module, while Metadata has no need for that.

As we look at supporting profile directed inlining, we'll need the full ModuleEnvironment around to be able to compile functions after runtime. Merging these two classes seems like it would make sense. In order to avoid regressing current workloads, we could free the memory in the FuncDesc vector conditionally for if the inlining flag is enabled.

Comment 1

[Julian Seward [:jseward]]

This is made redundant by bug 1891182; should we close this one?