DAMP tests doesn't wait for styleeditor to fetch the stylesheet content on page reload
Categories
(DevTools :: Style Editor, task)
Tracking
(firefox126 fixed)
| Tracking | Status | |
|---|---|---|
| firefox126 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
This ended up skewing tests when applying the patch queue from bug 1713093.
This will regress, expectedly, the reload tests of the styleeditor.
|
Assignee | |
Comment 1•1 year ago
|
||
The test wasn't really measuring anything meaningful and resolve abruptly.
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 2•1 year ago
|
||
This patch will regress styleditor tests. 62% on custom reload and 9% complicated reload:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=94e2cc1e39883c971998b0bfc9d0f4cff34450b5&originalSignature=4763542&newSignature=4763542&framework=12&application=firefox&originalRevision=032556b4e82cc425092f3af3a7032d5f05366974&page=1&showOnlyConfident=1
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
|
||
Comment 5•1 year ago
|
||
== Change summary for alert #41938 (as of Thu, 21 Mar 2024 10:03:21 GMT) ==
Regressions:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 69% | damp custom.styleeditor.reload.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender | 364.15 -> 617.02 |
| 68% | damp custom.styleeditor.reload.DAMP | macosx1015-64-shippable-qr | e10s fission stylo webrender-sw | 301.41 -> 506.00 |
| 63% | damp custom.styleeditor.reload.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender | 433.99 -> 705.32 |
| 62% | damp custom.styleeditor.reload.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender-sw | 360.16 -> 583.17 |
| 58% | damp custom.styleeditor.reload.DAMP | macosx1015-64-shippable-qr | e10s fission stylo webrender | 313.65 -> 496.01 |
| 57% | damp custom.styleeditor.reload.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 428.70 -> 674.00 |
| 24% | damp custom.styleeditor.close.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender-sw | 10.83 -> 13.43 |
| 23% | damp complicated.styleeditor.close.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 11.61 -> 14.33 |
| 22% | damp custom.styleeditor.close.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender | 10.66 -> 13.00 |
| 20% | damp complicated.styleeditor.close.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender-sw | 12.18 -> 14.68 |
| ... | ... | ... | ... | ... |
| 10% | damp complicated.styleeditor.reload.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 1,137.59 -> 1,251.64 |
| 10% | damp complicated.styleeditor.reload.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender | 1,188.04 -> 1,301.40 |
| 7% | damp complicated.styleeditor.reload.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender-sw | 1,200.56 -> 1,290.21 |
| 7% | damp custom.netmonitor.reload.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender | 341.23 -> 365.47 |
| 7% | damp complicated.styleeditor.reload.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender | 1,208.78 -> 1,288.14 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=41938
Description
•