1885441 - [wpt-sync] Sync PR 45114 - [css-scroll-snap-2] Switch snapchanging to updated SnapEvents interface

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45114 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45114
Details from upstream follow.

David Awogbemila <[e-mail]> wrote:

[css-scroll-snap-2] Switch snapchanging to updated SnapEvents interface

This patch updates chromium snapchanging code so that snapchanging
events use the updated SnapEvents API[1].

[1]https://github.com/w3c/csswg-drafts/pull/9515

Bug: 329111147
Change-Id: I844fbbf9b43c1b5759ada0d341ce1532661d39a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5369682
Reviewed-by: Steve Kobes \<[e-mail]>
Commit-Queue: David Awogbemila \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1273042}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 45114 applied with additional changes from upstream: c9a1cb97473bb77fe4259d81a739f64e7f8ad167, 2817af77c7e8465130e93b5d4935e0887dd8ea81

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=75a2506997433b191383a8d7d1783327f9fcc5db

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests and 2 subtests

Status Summary

Firefox

OK : 9
PASS : 2
FAIL : 23[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 25[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 33[GitHub]
TIMEOUT: 6
NOTRUN : 2

Chrome

OK : 10
PASS : 2
FAIL : 36
ERROR : 2

Safari

OK : 9
FAIL : 33
TIMEOUT: 6
NOTRUN : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-scroll-snap-2/snapchanging/snapchanging-after-layout-change.tentative.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
  • snapchanging fires after layout change: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /css/css-scroll-snap-2/snapchanging/snapchanging-on-user-root-scroll.tentative.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: ERROR, Safari: TIMEOUT)
  • touch scrolling fires snapchanging.: FAIL (Chrome: FAIL, Safari: FAIL)
  • mouse wheel scroll triggers snapchanging.: FAIL (Chrome: FAIL, Safari: FAIL)
  • scrollbar dragging fires snapchanging.: FAIL (Chrome: FAIL, Safari: FAIL)
  • keyboard scroll triggers snapchanging.: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanging fires as scroll moves through different snap targets.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
  • snapchanging doesn't fire if scroll doesn't reach different snap targets.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
• /css/css-scroll-snap-2/snapchanging/snapchanging-on-user-scroll.tentative.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: ERROR, Safari: TIMEOUT)
  • touch scrolling fires snapchanging.: FAIL (Chrome: FAIL, Safari: FAIL)
  • mouse wheel scroll triggers snapchanging.: FAIL (Chrome: FAIL, Safari: FAIL)
  • scrollbar dragging fires snapchanging.: FAIL (Chrome: FAIL, Safari: FAIL)
  • keyboard scroll triggers snapchanging.: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanging fires as scroll moves through different snap targets.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
  • snapchanging doesn't fire if scroll doesn't reach different snap targets.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
• /css/css-scroll-snap-2/snapchanged/snapchanged-after-layout-change.tentative.html [wpt.fyi]
  • snapchanged fires after snap area is snapped to upon layout change.: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged fires after snap area is snapped to upon layout change without scroll.: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged fires when container stops snapping: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged fires when snap container no longer has snap areas: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-root-scroll.tentative.html [wpt.fyi]
  • snapchanged event fires after snap target changes via scrollTo: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged is not fired if snap target doesn't change on programmatic scroll: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-scroll.tentative.html [wpt.fyi]
  • snapchanged event fires after snap target changes via scrollTo: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged is not fired if snap target doesn't change on programmatic scroll: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/snapchanged/snapchanged-on-user-root-scroll.tentative.html [wpt.fyi]
  • snapchanged event fires after snap target changes on touch scroll: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged event fires after snap target changes on wheel scroll: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged event fires after snap target changes on scrollbar drag: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: FAIL)
  • snapchanged event fires after snap target changes on keydown press: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged is not fired if snap target doesn't change on user scroll: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/snapchanged/snapchanged-on-user-scroll.tentative.html [wpt.fyi]
  • snapchanged event fires after snap target changes on touch scroll: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged event fires after snap target changes on wheel scroll: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged event fires after snap target changes on scrollbar drag: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: FAIL)
  • snapchanged event fires after snap target changes on keydown press: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged is not fired if snap target doesn't change on user scroll: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/snapchanged/snapchanged-same-targets-after-layout-changed.html [wpt.fyi]
  • snapchanged doesn't fire after layout change if snapped to the same elements: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanged doesn't fire after snap to the same targets after scroll. elements: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/snapchanged/snapchanged-with-proximity-strictness.tentative.html [wpt.fyi]
  • Snapchanged fires when scrolling outside proximity range.: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/snapchanging/snapchanging-on-programmatic-root-scroll.tentative.html [wpt.fyi]
  • snapchanging fires on programmatic scrolls that changes a scroller's snap targets.: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanging does not fire on programmatic scrolls that don't trigger a change in snap targets.: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/snapchanging/snapchanging-on-programmatic-scroll.tentative.html [wpt.fyi]
  • snapchanging fires on programmatic scrolls that changes a scroller's snap targets.: FAIL (Chrome: FAIL, Safari: FAIL)
  • snapchanging-on-programmatic-scroll: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /css/css-scroll-snap-2/snapchanging/snapchanging-after-layout-change.tentative.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
• /css/css-scroll-snap-2/snapchanging/snapchanging-on-user-root-scroll.tentative.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: ERROR, Safari: TIMEOUT)
• /css/css-scroll-snap-2/snapchanging/snapchanging-on-user-scroll.tentative.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: ERROR, Safari: TIMEOUT)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/023f7b3a025c
[wpt PR 45114] - [css-scroll-snap-2] Switch snapchanging to updated SnapEvents interface, a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/023f7b3a025c