1885572 - Add to TelemetryEnvironment activeAddons properties the signature types found on signed xpi files

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As a followup to adding an AddonWrapper property to retrieve the array of signature types found on signed XPI files, we want to collect that additional property as part of the TelemetryEnvironment activeAddons, this technical data will be helpful in assessments related the signature types still used by extensions active across the Firefox clients reporting telemetry (while at the moment that kind of assessment requires querying separately AMO DB and Firefox telemetry and then correlated the data available on the AMO side with the data got through the existing Firefox telemetry).

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1885572 - Add to TelemetryEnvironment activeAddons properties the signature types found on signed xpi files. r?willdurand!,chutten!

Depends on D204686

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1885572 - Add to TelemetryEnvironment new xpinstall about:config pref controlling restrictions on deprecated XPI signatures. r?willdurand!,chutten!

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: bug1885572_request.md

Comment 4

[Chris H-C :chutten]

Comment on attachment 9392126 [details]
bug1885572_request.md

PRELIMINARY NOTES:

The data collection review itself must be available to the audience having their data collected when that data is being collected. Luca: Will this bug be made non-conf before the patch reaches users?

I will continue with this data collection review under the assumption that it will.

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through the product's preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Luca Greco and the Add-ons Team are responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+, so long as this bug is made public before data begins to be collected.

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Chris H-C :chutten from comment #4)

...
Result: datareview+, so long as this bug is made public before data begins to be collected.

Hi Dan, as Chris pointed out at the end of comment 4 the data review request is to be considered approved as long as this bug will be public before the data collection begins, technically that would start in nightly builds as soon as we land the patch (and then on other channels while the new probes are riding the release train).

Do you think we can make this bug public soon after we will be landing these patches?
Could also the other bugs tracking the other parts of the same set of changes (or a subset of them) be also made public similarly when we are landing those patches?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1844d5b251e3
Add to TelemetryEnvironment activeAddons properties the signature types found on signed xpi files. r=willdurand,chutten
https://hg.mozilla.org/integration/autoland/rev/9d85ceb2b276
Add to TelemetryEnvironment new xpinstall about:config pref controlling restrictions on deprecated XPI signatures. r=willdurand,chutten

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1844d5b251e3
https://hg.mozilla.org/mozilla-central/rev/9d85ceb2b276