1885586 - [Menu Redesign] Implement scrolling

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P3)

Description

[Roger Yang [:royang]]

Implement scrolling when the menu is at max height.
Design here: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=10858-65895&mode=design&t=lu0I4xY5gKXPXbUz-4

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885586 - Part 1: Introduce a MenuScaffold composable that provides the layout of the menu header and content

• This refactors the existing Columns and Spacers that is used to for the menu header and content layout, which
  is reused in our main menu and submenus

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885586 - Part 2 Implement scrolling of the menu content in MenuScaffold

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eaa64c0cf588
Part 1: Introduce a MenuScaffold composable that provides the layout of the menu header and content r=android-reviewers,007
https://hg.mozilla.org/integration/autoland/rev/915bb0581b36
Part 2 Implement scrolling of the menu content in MenuScaffold r=android-reviewers,007

Comment 4

[tszentpeteri]

Backed out for causing linting issues on ExtensionsSubmenu.kt.

• Backout link
• Push with failures
• Failure Log
• Failure log:

[task 2024-05-15T05:37:40.588Z] > Task :app:compileFenixDebugKotlin
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ExtensionsSubmenu.kt:29:9 No value passed for parameter 'content'
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ExtensionsSubmenu.kt:29:9: error: No value passed for parameter 'content'
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ExtensionsSubmenu.kt:35:7 Type mismatch: inferred type is () -> Unit but Modifier was expected
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ExtensionsSubmenu.kt:35:7: error: Type mismatch: inferred type is () -> Unit but Modifier was expected
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ExtensionsSubmenu.kt:36:9 @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ExtensionsSubmenu.kt:36:9: error: @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ExtensionsSubmenu.kt:44:9 @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ExtensionsSubmenu.kt:44:9: error: @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt:78:9 No value passed for parameter 'content'
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt:78:9: error: No value passed for parameter 'content'
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt:87:7 Type mismatch: inferred type is () -> Unit but Modifier was expected
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt:87:7: error: Type mismatch: inferred type is () -> Unit but Modifier was expected
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt:88:9 @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt:88:9: error: @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt:95:9 @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt:95:9: error: @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt:104:9 @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt:104:9: error: @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt:112:13 @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MainMenu.kt:112:13: error: @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/SaveSubmenu.kt:36:9 No value passed for parameter 'content'
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/SaveSubmenu.kt:36:9: error: No value passed for parameter 'content'
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/SaveSubmenu.kt:42:7 Type mismatch: inferred type is () -> Unit but Modifier was expected
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/SaveSubmenu.kt:42:7: error: Type mismatch: inferred type is () -> Unit but Modifier was expected
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/SaveSubmenu.kt:43:9 @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/SaveSubmenu.kt:43:9: error: @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ToolsSubmenu.kt:36:9 No value passed for parameter 'content'
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ToolsSubmenu.kt:36:9: error: No value passed for parameter 'content'
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ToolsSubmenu.kt:42:7 Type mismatch: inferred type is () -> Unit but Modifier was expected
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ToolsSubmenu.kt:42:7: error: Type mismatch: inferred type is () -> Unit but Modifier was expected
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ToolsSubmenu.kt:43:9 @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ToolsSubmenu.kt:43:9: error: @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ToolsSubmenu.kt:57:9 @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ToolsSubmenu.kt:57:9: error: @Composable invocations can only happen from the context of a @Composable function
[task 2024-05-15T05:38:18.488Z] 
[task 2024-05-15T05:38:18.488Z] > Task :app:compileFenixDebugKotlin FAILED
[task 2024-05-15T05:38:18.588Z] 
[task 2024-05-15T05:38:18.588Z] FAILURE: Build failed with an exception.
[task 2024-05-15T05:38:18.588Z] 
[task 2024-05-15T05:38:18.588Z] * What went wrong:
[task 2024-05-15T05:38:18.588Z] Execution failed for task ':app:compileFenixDebugKotlin'.
[task 2024-05-15T05:38:18.588Z] > A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
[task 2024-05-15T05:38:18.588Z]    > Compilation error. See log for more details

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfd65a34b1ab
Part 1: Introduce a MenuScaffold composable that provides the layout of the menu header and content r=android-reviewers,007
https://hg.mozilla.org/integration/autoland/rev/5b2aa109c8d4
Part 2 Implement scrolling of the menu content in MenuScaffold r=android-reviewers,007

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/cfd65a34b1ab
https://hg.mozilla.org/mozilla-central/rev/5b2aa109c8d4