1885741 - clicking on anchor with empty fragment href inside an svg gives warning: Empty string passed to getElementById()

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[eyal gruss]

I have on <object> loading an external <svg> which contains <a> elements with href="#".
i want the empty fragment to allow tabstops. the anchor has a role as a button.
in firefox devtools i get "Empty string passed to getElementById()" when clicking the links, and the source of the error is the svg file.
i do not get this error on chromium. See here: https://oulipoh.com/resen/seasons

Comment 1

[Robert Longson [:longsonr]]

Attachment: Bug 1885741 - Check string isn't empty before passing to getElementById r=emilio

Comment 2

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=357b5584acbd843345a193e244a1c39985032972

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f0797227aaa
Check string isn't empty before passing to getElementById r=emilio

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0f0797227aaa

Comment 5

[Robert Longson [:longsonr]]

Comment on attachment 9391627 [details]
Bug 1885741 - Check string isn't empty before passing to getElementById r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: SVG use and animation elements with href="#" will result in console warnings. Pretty cosmetic but a prerequisite to fixing bug 1883804, and that bug I would like to get in beta if I manage to fix it.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: See comment 0 in the bug but its just a console warning, not a functional problem.

Note: The non-empty string case has plenty of automated tests.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple code change that avoids calling getElementById with an empty string, the code continues to call getElementById in all other circumstances.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1867225

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9391627 [details]
Bug 1885741 - Check string isn't empty before passing to getElementById r=emilio

Approved for 125.0b2.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ee438e81c37e