1885756 - [wpt-sync] Sync PR 45148 - [css-color] test conversion lossiness

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45148 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45148
Details from upstream follow.

Romain Menke <[e-mail]> wrote:

[css-color] test conversion lossiness

These tests are a bit over the top, so if someone has a suggestion for a more succinct test?

All these cases pass with at least 5 decimal places on my end, but most fail in Safari and Chrome. (Firefox doesn't support relative color syntax).

I would expect these to also pass in a browser, especially simple cases like this one:

color(from color(from color(rec2020 0.99 0.88 0.77) srgb r g b) rec2020 r g b)

• Chrome: color(rec2020 0.989868 0.879845 0.769978)
• Safari: color(rec2020 0.9531038 0.88519126 0.8055929)

When I was first testing with these values, I was mostly interested in how good implementations would perform at preserving the input after many conversions.
But given the results I think that even a single conversion is done incorrectly in some cases.

Should there be more exhaustive tests?
From all, to all notations and back for a wider range of values?

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=32c4ffbe8feb8f4c6fd86fe297400ba62344a420

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1011 subtests

## Status Summary

### Firefox
`OK`  : 1
`FAIL`: 1011

### Chrome
`OK`  : 1
`PASS`: 961
`FAIL`: 50

### Safari
`OK`  : 1
`PASS`: 749
`FAIL`: 262

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=32c4ffbe8feb8f4c6fd86fe297400ba62344a420)
[GitHub PR Head](https://wpt.fyi/results/?sha=d8c9608f05965fdfaa866feaa8536c0a83b3d0a8&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=d8c9608f05965fdfaa866feaa8536c0a83b3d0a8&label=pr_base)

## Details

(See attachment for full changes)

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1011 subtests

## Status Summary

### Firefox
`OK`  : 1
`FAIL`: 1011

### Chrome
`OK`  : 1
`PASS`: 961
`FAIL`: 50

### Safari
`OK`  : 1
`PASS`: 749
`FAIL`: 262

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=32c4ffbe8feb8f4c6fd86fe297400ba62344a420)
[GitHub PR Head](https://wpt.fyi/results/?sha=d8c9608f05965fdfaa866feaa8536c0a83b3d0a8&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=d8c9608f05965fdfaa866feaa8536c0a83b3d0a8&label=pr_base)

## Details

(See attachment for full changes)

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1011 subtests

## Status Summary

### Firefox
`OK`  : 1
`FAIL`: 1011

### Chrome
`OK`  : 1
`PASS`: 961
`FAIL`: 50

### Safari
`OK`  : 1
`PASS`: 749
`FAIL`: 262

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=32c4ffbe8feb8f4c6fd86fe297400ba62344a420)
[GitHub PR Head](https://wpt.fyi/results/?sha=d8c9608f05965fdfaa866feaa8536c0a83b3d0a8&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=d8c9608f05965fdfaa866feaa8536c0a83b3d0a8&label=pr_base)

## Details

(See attachment for full changes)

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1011 subtests

## Status Summary

### Firefox
`OK`  : 1
`FAIL`: 1011

### Chrome
`OK`  : 1
`PASS`: 961
`FAIL`: 50

### Safari
`OK`  : 1
`PASS`: 749
`FAIL`: 262

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=32c4ffbe8feb8f4c6fd86fe297400ba62344a420)
[GitHub PR Head](https://wpt.fyi/results/?sha=d8c9608f05965fdfaa866feaa8536c0a83b3d0a8&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=d8c9608f05965fdfaa866feaa8536c0a83b3d0a8&label=pr_base)

## Details

(See attachment for full changes)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19e67a628516
[wpt PR 45148] - [css-color] test conversion lossiness in relative color syntax, a=testonly
https://hg.mozilla.org/integration/autoland/rev/f53791765c64
[wpt PR 45148] - Update wpt metadata, a=testonly

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1011 subtests

## Status Summary

### Firefox
`OK`  : 1
`FAIL`: 1011

### Chrome
`OK`  : 1
`PASS`: 961
`FAIL`: 50

### Safari
`OK`  : 1
`PASS`: 749
`FAIL`: 262

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=32c4ffbe8feb8f4c6fd86fe297400ba62344a420)
[GitHub PR Head](https://wpt.fyi/results/?sha=d8c9608f05965fdfaa866feaa8536c0a83b3d0a8&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=d8c9608f05965fdfaa866feaa8536c0a83b3d0a8&label=pr_base)

## Details

(See attachment for full changes)

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/19e67a628516
https://hg.mozilla.org/mozilla-central/rev/f53791765c64