1885803 - Crash in [@ get_gtk_cursor_from_type]

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

60 crashes from 5 installs starting with build ID 20240316092555.

Crash report: https://crash-stats.mozilla.org/report/index/973da83e-f0ac-4c8c-936c-c76a30240317

Reason: SIGSEGV / SEGV_MAPERR

Top 10 frames of crashing thread:

0  libxul.so  get_gtk_cursor_from_type  widget/gtk/nsWindow.cpp:7884
1  libxul.so  get_gtk_cursor  widget/gtk/nsWindow.cpp
1  libxul.so  nsWindow::SetCursor  widget/gtk/nsWindow.cpp:3334
2  libxul.so  mozilla::dom::BrowserParent::SendRealMouseEvent  dom/ipc/BrowserParent.cpp:1477
3  libxul.so  mozilla::EventStateManager::DispatchCrossProcessEvent  dom/events/EventStateManager.cpp:1715
3  libxul.so  mozilla::EventStateManager::HandleCrossProcessEvent  dom/events/EventStateManager.cpp:1843
4  libxul.so  mozilla::EventStateManager::DispatchMouseOrPointerEvent  dom/events/EventStateManager.cpp:4732
5  libxul.so  mozilla::EventStateManager::NotifyMouseOver  dom/events/EventStateManager.cpp:4942
6  libxul.so  mozilla::EventStateManager::GenerateMouseEnterExit  dom/events/EventStateManager.cpp:5081
7  libxul.so  mozilla::EventStateManager::PreHandleEvent  dom/events/EventStateManager.cpp:850

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1885803 [Linux] Don't create cursor from invalid cursor type r?emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4203d6096c83
[Linux] Don't create cursor from invalid cursor type r=emilio

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4203d6096c83

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9391708 [details]
Bug 1885803 [Linux] Don't create cursor from invalid cursor type r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: Startup crash if missing cursor.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adding check we have a valid cursor.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9391708 [details]
Bug 1885803 [Linux] Don't create cursor from invalid cursor type r?emilio

Approved for 125.0b3.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/1464cc28509d

Comment 9

[Wayne Mery (:wsmwk)]

No g_str_hash crash signatures for Thunderbird 125.0b2, which is the first beta to have this patch.