1885948 - IPDL build error: CreateProcess(...) failed / make (e=87): The parameter is incorrect.

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Beth Rennie [:beth] (she/her)]

Attachment: build log

When I attempt a non-artifact build with commit 2333872b0f50 (a recent central), I get the attached build error. I believe this is happening because the second argument to CreateProcess() is over the maximum of 32,768 characters (it is 33064).
My source checkout is at C:\Users\Barret\Workspace\src\hg.mozilla.org\mozilla-central, which I don't think is too egregious of a path, but it accounts for 12784 of those characters.

We should consider a refactor of ipdl.py that reads in these filename from a file instead of passing them on the commandline.

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1885948 - Pass IPDL sources to ipdl.py in a text file r?nika!,ahochheiden!

If the path to your source checkout on Windows is sufficiently long enough, you
can hit the Windows maximum commandline argument limit (32k) specifying IPDL
files to ipdl.py during build. Writing the list of files to a file and passing
that to ipdl.py gets around this error completely.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1428617e87a
Pass IPDL sources to ipdl.py in a text file r=nika,ahochheiden

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing mbu failures

• backout: https://hg.mozilla.org/integration/autoland/rev/bbf9b36eacdf83dd22cebb24328a49efb184d077
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Xdm0CZQ5TWKYTFDbWF5nxw.0&revision=a1428617e87a31280ec3e538848d0030b46588e8
• failure log: https://treeherder.mozilla.org/logviewer?job_id=451226224&repo=autoland&lineNumber=2399

[task 2024-03-19T05:47:34.130Z] python/mozbuild/mozbuild/test/backend/test_recursivemake.py::TestRecursiveMakeBackend::test_ipdl_sources TEST-UNEXPECTED-FAIL
[task 2024-03-19T05:47:34.133Z] =================================== FAILURES ===================================
[task 2024-03-19T05:47:34.133Z] __________________ TestRecursiveMakeBackend.test_ipdl_sources __________________
[task 2024-03-19T05:47:34.133Z] python/mozbuild/mozbuild/test/backend/test_recursivemake.py:815: in test_ipdl_sources
[task 2024-03-19T05:47:34.133Z]     self.assertEqual(found, expected)
[task 2024-03-19T05:47:34.133Z] E   AssertionError: Lists differ: ['ALL[435 chars]h', 'ALL_IPDLSRCS_FILE := /builds/worker/check[394 chars]foo'] != ['ALL[435 chars]h', 'IPDLDIRS := /builds/worker/checkouts/geck[253 chars]foo']
[task 2024-03-19T05:47:34.133Z] E
[task 2024-03-19T05:47:34.133Z] E   First differing element 1:
[task 2024-03-19T05:47:34.133Z] E   'ALL_IPDLSRCS_FILE := /builds/worker/check[92 chars].txt'
[task 2024-03-19T05:47:34.133Z] E   'IPDLDIRS := /builds/worker/checkouts/geck[252 chars]/foo'
[task 2024-03-19T05:47:34.133Z] E
[task 2024-03-19T05:47:34.133Z] E   First list contains 1 additional elements.
[task 2024-03-19T05:47:34.133Z] E   First extra element 2:
[task 2024-03-19T05:47:34.133Z] E   'IPDLDIRS := /builds/worker/checkouts/gecko/python/mozbuild/mozbuild/test/backend/data/ipdl_sources/tmpduwm2uf3/ipdl /builds/worker/checkouts/gecko/python/mozbuild/mozbuild/test/backend/data/ipdl_sources/bar /builds/worker/checkouts/gecko/python/mozbuild/mozbuild/test/backend/data/ipdl_sources/foo'
[task 2024-03-19T05:47:34.133Z] E
[task 2024-03-19T05:47:34.133Z] E   Diff is 942 characters long. Set self.maxDiff to None to see it.
[task 2024-03-19T05:47:34.133Z] ------------------------------ Captured log call -------------------------------

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49f6b516c694
Pass IPDL sources to ipdl.py in a text file r=nika,ahochheiden

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/49f6b516c694