1886123 - Theme selection doesn't work after accessing a custom tab in dark theme

Status: VERIFIED FIXED

(Firefox for Android :: General, defect)

Description

[Lorand Janos]

Attachment: Recorder_12032024_081815 (1).mp4

Steps to reproduce

1. Open Fenix, and set it as default Browser.
2. Go to Settings -> Customize and check the "Dark" theme.
3. Close the app.
4. Open an external app i.e. Gmail and tap on a link to open a custom tab.
5. Reopen Fenix and observe the theme. Check in Settings -> Customize the selected theme.
6. Try selecting dark theme by switching between light and dark or follow device theme (with the device theme set to dark).

Expected behavior

The dark theme can be set.

Actual behavior

Only the light theme is active, the dark theme cannot be set.

Device information

• Firefox version: Nightly 125.0a1
• Android device model: Samsung Galaxy S23 Ultra
• Android OS version: Android 14

Any additional information?

Reproduced with the latest Nightly 126.0a1, Nightly 125.0a1 and latest Beta 125.0b1.

Comment 1

[twhite]

Attachment: Bug 1886123 - Removed unnecessary setting of app dark mode which was causing theming bug.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f515047f59a1
Removed unnecessary  setting of app dark mode which was causing theming bug. r=android-reviewers,amejiamarmol

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f515047f59a1

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:towhite, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Lorand Janos]

This issue is no longer reproducible on the latest Nightly build (126.0a1 from 2024-03-22).
The dark theme remains set and can be changed after accessing a custom tab with the dark theme set previously.
Device used: Samsung Galaxy S23 Ultra (Android 14).
Marking the ticket as verified on 126.

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Uplift request: Bug 1886123 - Removed unnecessary setting of app dark mode which was causing theming (#6053)

Comment 7

[twhite]

Comment on attachment 9393072 [details] [review]
[mozilla-mobile/firefox-android] Uplift request: Bug 1886123 - Removed unnecessary setting of app dark mode which was causing theming (#6053)

Beta/Release Uplift Approval Request

• User impact if declined: App dark mode theming issues
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Details in bug.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Verified on Nightly, automated tests
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9393072 [details] [review]
[mozilla-mobile/firefox-android] Uplift request: Bug 1886123 - Removed unnecessary setting of app dark mode which was causing theming (#6053)

Approved for 125.0b5.

Comment 9

[BMO Github Automation]

Authored by https://github.com/t-p-white
https://github.com/mozilla-mobile/firefox-android/commit/f44ae0f2e80f6766cbccc2e0939a00f500ed4ebe
[releases_v125] Bug 1886123 - Removed unnecessary setting of app dark mode which was causing theming bug. r=android-reviewers,amejiamarmol

Comment 10

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: az_recorder_20240328_120241.mp4

This issue is verified as fixed on Firefox 125 Beta 5 using Sony Z5 (Android 7.1.1), Assus Zenfone 9 ( Android 13) and Samsung Galaxy Tab S8 Ultra (Android 12). The themes are correctly set according to the selected option.