1886170 - [css-color] Remove the ColorParser abstraction.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Description

[Tiaan Louw [:tlouw]]

There is no more need for the ColorParser as it now only forwards into the ColorFunction enum.

Comment 1

[Tiaan Louw [:tlouw]]

Attachment: Bug 1886170 - Remove ColorParser r=#layout

The ColorParser is not used any more as now it only forwards to the
ColorFunction enum.

Comment 2

[Tiaan Louw [:tlouw]]

Attachment: Bug 1886170 - Add ColorFunction enum r=#layout

Add a ColorFunction enum that can hold the results of a parsed color
with all the required information still intact.

Comment 3

[Tiaan Louw [:tlouw]]

Attachment: Bug 1886170 - Remove ColorParser::Output abstraction r=#layout

This abstraction was in place when the color parsing still lived in
the cssparser crate, but now it is not needed any more and by removing
it we make the parsing more flexible.

Note: the ColorParser trait itself is still in tact and will be
addressed in another patch.

Depends on D207007

Comment 4

[Tiaan Louw [:tlouw]]

Attachment: Bug 1886170 - Change Color Parser trait into a concrete type r=#layout

The ColorParser trait only has one implementation so we can make it a
concrete type now. It will be extended in the future.

Depends on D207008

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/279d170d3e2b
Add ColorFunction enum r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/065f4b75e320
Remove ColorParser::Output abstraction r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/3b4ceebe267a
Change Color Parser trait into a concrete type r=layout-reviewers,emilio

Comment 6

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/279d170d3e2b
https://hg.mozilla.org/mozilla-central/rev/065f4b75e320
https://hg.mozilla.org/mozilla-central/rev/3b4ceebe267a