Get rid of nsITextFrame

RESOLVED FIXED in mozilla1.4alpha

Status

()

Core
Layout: Text
P1
normal
RESOLVED FIXED
15 years ago
14 years ago

People

(Reporter: smontagu, Unassigned)

Tracking

({footprint})

Trunk
mozilla1.4alpha
x86
Windows 2000
footprint
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

15 years ago
email from Chris Waterson:

Just noticed that text frame needs to implement nsITextFrame for bidi. That adds
an extra word of overhead for each text frame, which would be nice to avoid. Any
chance we could figure out how to do bidi _without_ the extra interface?
Personally, I'm okay with promoting required methods up to nsIFrame, and just
stubbing them in nsFrame.

Updated

15 years ago
Keywords: footprint
Priority: -- → P1
Target Milestone: --- → Future
(Reporter)

Comment 1

15 years ago
Created attachment 113149 [details] [diff] [review]
Patch
(Reporter)

Updated

15 years ago
Attachment #113149 - Flags: superreview?(roc+moz)
Attachment #113149 - Flags: review?(sfraser)
Comment on attachment 113149 [details] [diff] [review]
Patch

why have the pure virtuals on nsIFrame?  Just put the NS_ERROR_NOT_IMPLEMENTED
up there.... (or, since you never check the retval make it a virtual void)
Comment on attachment 113149 [details] [diff] [review]
Patch

Please make the methods 'virtual void' (COM bad!), move the implementions to
nsIFrame and make them empty, and add comments to explain what they do. The
rest looks good.

r+sr=roc+moz

When my nsIFrame deCOMtamination lands, I'll want to change the offsets to be a
reference to an nsContentRange and I'll probably rename the methods too. But
don't worry about that for now.
Attachment #113149 - Flags: superreview?(roc+moz)
Attachment #113149 - Flags: superreview+
Attachment #113149 - Flags: review?(sfraser)
Attachment #113149 - Flags: review+
(Reporter)

Comment 4

15 years ago
Created attachment 113210 [details] [diff] [review]
Patch v.2 with changes requested by roc
(Reporter)

Updated

15 years ago
Attachment #113149 - Attachment is obsolete: true
(Reporter)

Comment 5

15 years ago
Comment on attachment 113210 [details] [diff] [review]
Patch v.2 with changes requested by roc

Transferring r+sr=roc+moz and requesting approval. This is a footprint win with
no semantic change, so risk is minimal.
Attachment #113210 - Flags: superreview+
Attachment #113210 - Flags: review+
Attachment #113210 - Flags: approval1.3b?

Comment 6

15 years ago
Comment on attachment 113210 [details] [diff] [review]
Patch v.2 with changes requested by roc

Please hold this cleanup until we open for 1.4alpha. Thanks.
Attachment #113210 - Flags: approval1.3b? → approval1.3b-
(Reporter)

Updated

15 years ago
Target Milestone: Future → mozilla1.4alpha
(Reporter)

Comment 7

15 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Created attachment 131569 [details] [diff] [review]
remove nsTextFrame::QueryInterface too
Attachment #131569 - Flags: superreview?(bz-vacation)
Attachment #131569 - Flags: review?(bz-vacation)
Comment on attachment 131569 [details] [diff] [review]
remove nsTextFrame::QueryInterface too

r+sr=bzbarsky
Attachment #131569 - Flags: superreview?(bz-vacation)
Attachment #131569 - Flags: superreview+
Attachment #131569 - Flags: review?(bz-vacation)
Attachment #131569 - Flags: review+
Comment on attachment 131569 [details] [diff] [review]
remove nsTextFrame::QueryInterface too

Checked in, 2003-09-16 15:04 -0700.
You need to log in before you can comment on or make changes to this bug.