Closed Bug 1886377 Opened 1 year ago Closed 1 year ago

Fix substring attribute selectors for Servo

Categories

(Core :: CSS Parsing and Computation, task)

task

Tracking

()

RESOLVED FIXED
126 Branch
Tracking Status
firefox126 --- fixed

People

(Reporter: Oriol, Assigned: Oriol)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Substring attribute selectors should never match when an empty string is provided.
The logic for [attr^=""], [attr$=""] , [attr*=""] and [attr~=""] is wrong.
Servo broke after bug 1837734 removed never_matches, which used to hide the problem.
Gecko doesn't use that code so it's fine.

Blocks: 1886376

Substring attribute selectors should never match when an empty string is
provided. This fixes [attr^=""], [attr$=""], [attr*=""] and [attr~=""]
in Servo, which broke when D180529 removed never_matches.

Gecko doesn't use this code at all, so no change in behavior.

Pushed by oriol-bugzilla@hotmail.com: https://hg.mozilla.org/integration/autoland/rev/0d744e313b06 Fix substring attribute selectors for Servo. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: