1886401 - Minor clean-up in `CGPerSignatureCall`

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), task)

Description

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

That method is roughly 400 lines long and needs to be extended for https://bugzilla.mozilla.org/show_bug.cgi?id=1884943. In it's current state, it's already too complex.

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1886401: part 1) Factor determening the `Deprecated` extended attribute's value out of `CGPerSignatureCall::__init__`. r=peterv

CGPerSignatureCall::__init__ consists of roughly 400 lines. It needs
to be extended, hence simplifying it before.

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1886401: part 2) Replace `getter`, `setter`, `isConstructor` with an enum `CallType` in `CGPerSignaturecall`. r=peterv

Since they're mutually exclusive.

Depends on D205198

Comment 3

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1886401: part 3) Factor determining arg description for argument conversion out of `CGPerSignatureCall::__init__`. r=peterv

Depends on D205199

Comment 4

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1886401: part 4) Factor determining found-non-finite-float-behavior out of `CGPerSignaturecall::__init__`. r=peterv

Depends on D205200

Comment 5

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1886401: part 5) Rename `errorReportingLabel` to `customErrorReportingLabel`. r=peterv

That's what it is.

Depends on D205202

Comment 6

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1886401: part 6) Factor determining error reporting label out. r=peterv

Depends on D205218

Comment 7

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1886401: part 1) Use `self.idlNode` instead of `idlNode` argument in `processWebExtensionStubAttribute`. r=peterv

Less confusing.

Depends on D205219

Comment 8

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1886401: part 2) Correct part of `CGPerSignatureCall`'s documentation. r=peterv

See
https://searchfox.org/mozilla-central/rev/b73676a106c1655030bb876fd5e0a6825aee6044/dom/bindings/Codegen.py#9361,9363.

Depends on D205222

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c117daa38ad
part 1) Use `self.idlNode` instead of `idlNode` argument in `processWebExtensionStubAttribute`. r=peterv
https://hg.mozilla.org/integration/autoland/rev/f8bc19bbd8de
part 2) Correct part of `CGPerSignatureCall`'s documentation. r=peterv

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3c117daa38ad
https://hg.mozilla.org/mozilla-central/rev/f8bc19bbd8de