1886427 - Voice Over focus frame is bigger than the highlighted text

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: HighlightFrame.png

Found in

• Nightly 126.0a1 (2024-03-19)

Affected versions

• Nightly 126.0a1 (2024-03-19)

Affected platforms

• MacOs

Preconditions:
Enable pdfjs.enableHighlightEditor - true
pdfjs.enableHighlightFloatingButton - true
Enable Voice Over.

Steps to reproduce

1. Open any PDF in Firefox.
2. Highlight any text.
3. Reach he highlighted text with the Voice Over commands.

Expected result

• The Voice Over frame should be as big as the Highlight.

Actual result

• The Voice Over frame displayed when reaching a Highlighted text is a lot bigger.
  More text is Highlighted the bigger the Voice over frame gets.

Regression range
Not a regression.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Make sure the text in the mark has null dimensions to avoid to see a meaningless rectangle in voiceover (bug 1886427) (#17814)

Comment 2

[Morgan Reschenberg [:morgan]]

S3'ing because the frame doesn't obscure much, even though the size is wrong. This could be an S2 if another actionable control falls into the center of the incorrect rect and receives clicks when a user activates the incorrectly sized item.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 4

[Rares Doghi, Desktop QA]

Attachment: VoiceOver frame.

The Voice Over frame is covering the entire PDF frame instead of the smaller Highlight. The issue still occurs a bit worse than before.
@Calixte can you take a look ?

Comment 5

[Rares Doghi, Desktop QA]

I will mark this issue Verified as fixed since the updates for this landed in both Beta as well as our latest Nightly builds but the improvements on this issues is carried on in Bug 1889623.