Closed
Bug 1886432
Opened 7 months ago
Closed 7 months ago
Improve Wasm code encoder for builtin modules creation
Categories
(Core :: JavaScript: WebAssembly, enhancement)
Core
JavaScript: WebAssembly
Tracking
()
RESOLVED
FIXED
126 Branch
| Tracking | Status | |
|---|---|---|
| firefox126 | --- | fixed |
People
(Reporter: yury, Assigned: yury)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Several utilities that might be useful when module is generated in the C++ code. Coping from the https://phabricator.services.mozilla.com/D200518 review:
-
StructType::createImmutable (instead of BuildSimpleStruct)
-
Added ModuleEnvironment's addDefinedFunc
a) bool addDefinedFunc(ValTypeVec&& params, ValTypeVec&& result, UniqueChars* optionalExportedName)
b) bool addImportedFunc(ValTypeVec&& params, ValTypeVec&& result, UniqueChars importModName, UniqueChars importFieldName)
Each of those would create the FuncType and add to types, then add the FuncDesc, then any import/export, then declare as exported if needed.
|
Assignee | |
Updated•7 months ago
|
Summary: Improved Wasm code encoder → Improve Wasm code encoder for builtin modules creation
|
|
Assignee | |
Comment 1•7 months ago
|
||
|
||
Updated•7 months ago
|
Assignee: nobody → ydelendik
Status: NEW → ASSIGNED
Pushed by ydelendik@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0bc66b10867c
Improve Wasm code encoder for builtin modules. r=rhunt
|
||
Comment 3•7 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
status-firefox126:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•