1886485 - Add additional test coverage related to AOM weak signature restrictions

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

This bugzilla issue tracks following up to Bug 1885004 by introducing a few more tests (in addition to the ones already included in Bug 1885004 patch):

• couple new unit tests to cover on expected restriction applied when an xpi signed with weak signatures is being installed over an existing addon using a stronger signature (and also test updating a existing addon signed with a weak signature successfully updating to one using a stronger signature), this part of the task depends also on Bug 1886252 (which is tracking resigning signed test extension xpi part of mozilla-central test suites)

• add a new mochitest-browser test to explicitly cover the doorhanger expected to be shown to users on install failure due to weak signature xpi files, this part only depends on Bug 1885004

• add a new test to explicitly cover behaviors expected on addons being installed through Firefox Sync

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1886485 - Add test coverage for behavior expected on weak signed xpi install attempt triggered from sync. r?willdurand,markh!

Depends on D204686

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1886485 - Add additional tests to cover updating installed addon between old and recent signatures. r?willdurand!

Depends on D205350

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1886485 - Removed unused toolkit/mozapps/extensions/test/xpinstall/restartless.xpi install.rdf based signed test xpi. r?willdurand!

This old signed xpi file seems to be unused from quite some time, it is likely a left-over from a
cleanup done between Firefox 60 and Firefox 68 (e.g. in mozilla-esr60 we can still find a reference to this file
from 2 mochitest browser ini files: https://searchfox.org/mozilla-esr60/search?q=xpinstall%2Frestartless.xpi&path=&case=false&regexp=false).

Currently it seems we don't have any test left to be still using this particular signed xpi and so this patch
just removes it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a6b16b0465e
Add test coverage for behavior expected on weak signed xpi install attempt triggered from sync. r=willdurand,markh,sync-reviewers
https://hg.mozilla.org/integration/autoland/rev/69ae66b9eb6d
Add additional tests to cover updating installed addon between old and recent signatures. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/9fe803ec0428
Removed unused toolkit/mozapps/extensions/test/xpinstall/restartless.xpi install.rdf based signed test xpi. r=willdurand

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3a6b16b0465e
https://hg.mozilla.org/mozilla-central/rev/69ae66b9eb6d
https://hg.mozilla.org/mozilla-central/rev/9fe803ec0428