Closed Bug 1886547 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 45223 - Support default button in appearance:bikeshed <select>

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox126 fixed)

RESOLVED FIXED
126 Branch
Tracking Status
firefox126 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45223 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45223
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Support default button in appearance:bikeshed <select>

This patch makes \<select> with appearance:bikeshed work when the author
does not provide a child \<button> element to slot in.

A fallback \<button> is added in the UA shadowroot's button slot which
will get rendered and have all the behaviors added to it.

Bug: 1511354
Change-Id: I0c3c744fd2704b48ac62c533f3c78cf7a3ed4e55

Reviewed-on: https://chromium-review.googlesource.com/5354708
WPT-Export-Revision: 8ac0bb6558cd292c210924369695c090decdffed

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 8 subtests

Status Summary

Firefox

FAIL : 1
TIMEOUT: 1
ERROR : 1
NOTRUN : 7

Chrome

CRASH : 1
TIMEOUT: 1

Safari

FAIL : 1
TIMEOUT: 1
ERROR : 1
NOTRUN : 7

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/forms/the-select-element/stylable-select/select-appearance-no-button-custom-datalist.tentative.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • /html/semantics/forms/the-select-element/stylable-select/select-keyboard-behavior.tentative.html [wpt.fyi]: ERROR (Chrome: CRASH, Safari: ERROR)
    • defaultbutton: When the listbox is closed, spacebar should open the listbox.: FAIL (Safari: FAIL)
    • defaultbutton: When the listbox is closed, all arrow keys should open the listbox.: NOTRUN (Safari: NOTRUN)
    • defaultbutton: When the listbox is closed, the enter key should submit the form or do nothing.: NOTRUN (Safari: NOTRUN)
    • defaultbutton: When the listbox is open, the enter key should commit the selected option.: NOTRUN (Safari: NOTRUN)
    • custombutton: When the listbox is closed, spacebar should open the listbox.: NOTRUN (Safari: NOTRUN)
    • custombutton: When the listbox is closed, all arrow keys should open the listbox.: NOTRUN (Safari: NOTRUN)
    • custombutton: When the listbox is closed, the enter key should submit the form or do nothing.: NOTRUN (Safari: NOTRUN)
    • custombutton: When the listbox is open, the enter key should commit the selected option.: NOTRUN (Safari: NOTRUN)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9281b74639b6 [wpt PR 45223] - Support default button in appearance:bikeshed <select>, a=testonly https://hg.mozilla.org/integration/autoland/rev/ff65800aded6 [wpt PR 45223] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.