1886694 - The weather suggest content is not centered while it is displayed on 4 rows

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: weather UI.png

[Affected versions]:

• Firefox Release 124.0 (Build ID: 20240311145044)
• Firefox Beta 125.0b1 (Build ID: 20240318085508)
• Firefox Nightly 126.0a1 (Build ID: 20240319093523)

[Affected Platforms]:

• Windows 10
• macOS 13.1
• Linux Mint 20.1

[Prerequisites]:

• Have the following prefs set:
  browser.urlbar.quicksuggest.enabled = true
  browser.urlbar.suggest.weather = true
  browser.urlbar.weather.featureGate = true
  browser.urlbar.weather.ignoreVPN = true
  browser.search.region = US

[Steps to reproduce]:

1. Open the Firefox with the profile from prerequisites.
2. Type in the urlbar a keyword that triggers the Weather suggestions (eg: weather).
3. Resize the browser until the weather suggestions content is displayed on 4 rows while the "Feedback" button is also displayed.
4. Observe the weather suggestion.

[Expected result]:

• The weather suggestions content is centered (the text + the icon).

[Actual result]:

• The weather suggestions content (the icon and the text) are not centered.

[Notes]:

• Attached is a screenshot of the issue.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1886694 - Center-align the weather row in the urlbar view, take 2.

My fix in bug 1878190 D200402 was totally wrong. It only added centering when
the view wraps.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f49641caf090
Center-align the weather row in the urlbar view, take 2. r=dao,desktop-theme-reviewers

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 9392468 [details]
Bug 1886694 - Center-align the weather row in the urlbar view, take 2.

Beta/Release Uplift Approval Request

• User impact if declined: Part of the weather suggestion in the address bar will remain uncentered
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Should be clear from comments
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Zero risk: This is a tiny CSS styling change
• String changes made/needed:
• Is Android affected?: No

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f49641caf090

Comment 5

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 126.0a1 (Build ID: 20240321211715) on Windows 10 x64, macOS 13.1 and Linux Mint 20.1.

• The weather suggestions content (the icon and the text) are centered even if the content is displayed on 3, 4 or 5 rows.

I will also verify the issue on Beta 125 as soon as the patch lands.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9392468 [details]
Bug 1886694 - Center-align the weather row in the urlbar view, take 2.

Approved for 125.0b4.

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/3ea8d7bbcce1

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Beta 125.0b4 (Build ID: 20240325091408) on Windows 10 x64, macOS 13.1 and Linux Mint 20.1.

• The weather suggestions content (the icon and the text) are centered even if the content is displayed on 3, 4 or 5 rows.