Closed Bug 1886694 Opened 2 months ago Closed 2 months ago

The weather suggest content is not centered while it is displayed on 4 rows

Categories

(Firefox :: Address Bar, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
126 Branch
Tracking Status
firefox124 --- wontfix
firefox125 --- verified
firefox126 --- verified

People

(Reporter: cmuntean, Assigned: adw)

References

Details

Attachments

(2 files)

Attached image weather UI.png

[Affected versions]:

  • Firefox Release 124.0 (Build ID: 20240311145044)
  • Firefox Beta 125.0b1 (Build ID: 20240318085508)
  • Firefox Nightly 126.0a1 (Build ID: 20240319093523)

[Affected Platforms]:

  • Windows 10
  • macOS 13.1
  • Linux Mint 20.1

[Prerequisites]:

  • Have the following prefs set:
    browser.urlbar.quicksuggest.enabled = true
    browser.urlbar.suggest.weather = true
    browser.urlbar.weather.featureGate = true
    browser.urlbar.weather.ignoreVPN = true
    browser.search.region = US

[Steps to reproduce]:

  1. Open the Firefox with the profile from prerequisites.
  2. Type in the urlbar a keyword that triggers the Weather suggestions (eg: weather).
  3. Resize the browser until the weather suggestions content is displayed on 4 rows while the "Feedback" button is also displayed.
  4. Observe the weather suggestion.

[Expected result]:

  • The weather suggestions content is centered (the text + the icon).

[Actual result]:

  • The weather suggestions content (the icon and the text) are not centered.

[Notes]:

  • Attached is a screenshot of the issue.
Priority: -- → P3
Assignee: nobody → adw
Status: NEW → ASSIGNED
Priority: P3 → P1

My fix in bug 1878190 D200402 was totally wrong. It only added centering when
the view wraps.

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f49641caf090
Center-align the weather row in the urlbar view, take 2. r=dao,desktop-theme-reviewers
Flags: qe-verify+
Flags: in-testsuite-

Comment on attachment 9392468 [details]
Bug 1886694 - Center-align the weather row in the urlbar view, take 2.

Beta/Release Uplift Approval Request

  • User impact if declined: Part of the weather suggestion in the address bar will remain uncentered
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Should be clear from comments
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Zero risk: This is a tiny CSS styling change
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9392468 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch

I have verified this issue on the latest Nightly 126.0a1 (Build ID: 20240321211715) on Windows 10 x64, macOS 13.1 and Linux Mint 20.1.

  • The weather suggestions content (the icon and the text) are centered even if the content is displayed on 3, 4 or 5 rows.

I will also verify the issue on Beta 125 as soon as the patch lands.

Status: RESOLVED → VERIFIED

Comment on attachment 9392468 [details]
Bug 1886694 - Center-align the weather row in the urlbar view, take 2.

Approved for 125.0b4.

Attachment #9392468 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have verified this issue on the latest Beta 125.0b4 (Build ID: 20240325091408) on Windows 10 x64, macOS 13.1 and Linux Mint 20.1.

  • The weather suggestions content (the icon and the text) are centered even if the content is displayed on 3, 4 or 5 rows.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: