Closed Bug 1886732 Opened 1 year ago Closed 1 year ago

Update PDF.js to new version ae60221b0ec0aca11d70d0f04951706b86d77203 from 2024-03-20 15:23:10

Categories

(Firefox :: PDF Viewer, enhancement)

Product:
Firefox
Component:
PDF Viewer
Type:
enhancement

Tracking

()

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox126 --- affected

People

(Reporter: update-bot, Assigned: update-bot)

Details

(Whiteboard: [3pl-filed][task_id: WlPGT40RQUa6B7DtelDgkA])

Attachments

(1 obsolete file)

This update covers 13 commits. Here are the overall diff statistics, and then the commit information.

toolkit/components/pdfjs/content/build/pdf.mjs | 63 +++++++++--
toolkit/components/pdfjs/content/build/pdf.scripting.mjs | 4 +-
toolkit/components/pdfjs/content/build/pdf.worker.mjs | 36 +++--
toolkit/components/pdfjs/content/web/viewer-geckoview.css | 3 -
toolkit/components/pdfjs/content/web/viewer-geckoview.mjs | 82 +++++++++-----
toolkit/components/pdfjs/content/web/viewer.css | 5 +-
toolkit/components/pdfjs/content/web/viewer.mjs | 84 +++++++++-----
toolkit/components/pdfjs/moz.yaml | 4 +-
8 files changed, 187 insertions(+), 94 deletions(-)

3ac52ac35931cf400cc8a8f0d6d743e380d29899 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/3ac52ac35931cf400cc8a8f0d6d743e380d29899
Authored: 2024-03-20 15:25:13 +0100
Committed: 2024-03-20 15:25:13 +0100

[Editor] Make sure the text in the mark has null dimensions to avoid to see a meaningless rectangle in voiceover (bug 1886427)

Files Modified:

  • test/integration/highlight_editor_spec.mjs
  • web/annotation_editor_layer_builder.css

f6b215144d66e4e163ec1f033bc50c5b78ab4216 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/f6b215144d66e4e163ec1f033bc50c5b78ab4216
Authored: 2024-03-19 22:29:59 +0100
Committed: 2024-03-19 22:29:59 +0100

Simplify the copy & paste integration test

Files Modified:

  • test/integration/copy_paste_spec.mjs
  • test/integration/test_utils.mjs

a3873e4c68aa025f854ef6f7d2ce214e53e73a7b by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/a3873e4c68aa025f854ef6f7d2ce214e53e73a7b
Authored: 2024-03-19 15:17:44 +0100
Committed: 2024-03-19 18:36:55 +0100

Don't hide the editor layer when rotating (follow-up of #17802)

Before the patch in #17802, the layer was made visible when calling updateMode
after the rotation angle was set.

Files Modified:

  • src/display/editor/annotation_editor_layer.js
  • test/integration/freetext_editor_spec.mjs
  • web/annotation_editor_layer_builder.js

1b00511301840d413f3369f834999ee44d3dfa8d by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/1b00511301840d413f3369f834999ee44d3dfa8d
Authored: 2024-03-11 17:03:44 +0100
Committed: 2024-03-19 16:14:55 +0100

[Editor] Make the text layer focusable before the editors (bug 1881746)

Keep the different layers in a constant order to avoid the use of a z-index
and a tab-index.

Files Modified:

  • src/display/editor/annotation_editor_layer.js
  • src/display/editor/editor.js
  • src/display/editor/tools.js
  • test/integration/freetext_editor_spec.mjs
  • test/integration/highlight_editor_spec.mjs
  • test/integration/test_utils.mjs
  • web/annotation_editor_layer_builder.css
  • web/annotation_editor_layer_builder.js
  • web/annotation_layer_builder.css
  • web/annotation_layer_builder.js
  • web/pdf_page_view.js
  • web/pdf_viewer.css
  • web/text_layer_builder.css
  • web/text_layer_builder.js

5437199c95c46833834d0893135eb0583ba0b133 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/5437199c95c46833834d0893135eb0583ba0b133
Authored: 2024-03-18 10:29:28 +0100
Committed: 2024-03-18 10:29:32 +0100

[Editor] Fix the rect used to click in some freetext integration tests

And avoid to uselessly set the pointer listeners in the annotation editor layer.

Files Modified:

  • src/display/editor/annotation_editor_layer.js
  • test/integration/freetext_editor_spec.mjs

601bf580f9164bf920ff681535be28bc6b09c0fb by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/601bf580f9164bf920ff681535be28bc6b09c0fb
Authored: 2024-03-17 13:52:15 +0100
Committed: 2024-03-17 13:52:15 +0100

Update l10n files

Files Modified:

  • l10n/gn/viewer.ftl
  • l10n/it/viewer.ftl
  • l10n/nn-NO/viewer.ftl
  • l10n/pa-IN/viewer.ftl
  • l10n/tr/viewer.ftl

93c09b050270a1f133a868e131a0e83b546cc650 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/93c09b050270a1f133a868e131a0e83b546cc650
Authored: 2024-03-17 13:50:21 +0100
Committed: 2024-03-17 13:50:21 +0100

Update npm packages

Files Modified:

  • package-lock.json
  • package.json

a26fe9a902aa6219abe36db82678795974821329 by dependabot[bot]

https://github.com/mozilla/pdf.js/commit/a26fe9a902aa6219abe36db82678795974821329
Authored: 2024-03-16 23:00:41 +0000
Committed: 2024-03-16 23:00:41 +0000

Bump follow-redirects from 1.15.4 to 1.15.6

Bumps follow-redirects from 1.15.4 to 1.15.6.

updated-dependencies:

  • dependency-name: follow-redirects
    dependency-type: indirect
    ...

Signed-off-by: dependabot[bot] <support@github.com>

Files Modified:

  • package-lock.json

65d618635c72172ad9933b4a6da54756f42913e1 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/65d618635c72172ad9933b4a6da54756f42913e1
Authored: 2024-03-14 18:08:46 +0100
Committed: 2024-03-15 15:37:06 +0100

When zooming the scrollbar can disappear and then no scrollend is triggered

Files Added:

  • test/integration/viewer_spec.mjs

Files Modified:

  • test/integration-boot.mjs
  • web/app.js

9c3471dd01bdc9ee35c659caecc89d33556cbce8 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/9c3471dd01bdc9ee35c659caecc89d33556cbce8
Authored: 2024-03-14 21:23:26 +0100
Committed: 2024-03-15 15:33:18 +0100

Don't render corrupted inlined images

Fixes #17794.

Files Added:

  • test/pdfs/issue17794.pdf.link

Files Modified:

  • src/core/evaluator.js
  • test/test_manifest.json

eded037d060fb6dcdfa0342fc0f6a663e4f5596e by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/eded037d060fb6dcdfa0342fc0f6a663e4f5596e
Authored: 2024-02-21 16:04:13 +0100
Committed: 2024-02-21 22:38:42 +0100

[api-minor] Use the Fetch API, when supported, to load PDF documents in Node.js environments

Given that modern Node.js versions now implement support for a fair number of "browser" APIs, we can utilize the standard Fetch API to load PDF documents that are specified via http/https URLs.

Please find compatibility information at:

Files Modified:

  • src/display/api.js
  • test/unit/api_spec.js
  • test/unit/clitests.json
  • test/unit/fetch_stream_spec.js
  • test/unit/node_stream_spec.js
  • test/unit/test_utils.js

f295c51cc5fb5a7f61750578a72141422dc36b49 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/f295c51cc5fb5a7f61750578a72141422dc36b49
Authored: 2024-02-19 11:28:10 +0100
Committed: 2024-02-19 11:34:48 +0100

Use more optional chaining, and other modern JS, in the building code

Files Modified:

  • external/builder/babel-plugin-pdfjs-preprocessor.mjs
  • external/builder/builder.mjs
  • gulpfile.mjs

fbcb68360981188f57201e590d5c66429084fcf1 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/fbcb68360981188f57201e590d5c66429084fcf1
Authored: 2024-02-19 11:15:57 +0100
Committed: 2024-02-19 11:34:44 +0100

Move the alias-building out of the createWebpackConfig function

Over time, as we've started relying more and more on import maps, the number of aliases have increased a lot. This is now affecting the size and readability of createWebpackConfig, which was already fairly large and complex, hence moving the aliases to their own function should help improve things a little bit.

Files Modified:

  • gulpfile.mjs

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=bb9e4b43d0c4904ad91859c40c250e1d436c733e

Assignee: nobody → update-bot
Status: NEW → ASSIGNED

Closed in favor of bug 1886872.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX

The try push is done, we found jobs with unclassified failures.

Known Issues (From Push Health):

  • toolkit/components/pdfjs/test/browser_pdfjs_navigation.js

    • 2 of 2 failed on different tasks
      - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-1 (KhQzQf2cTV-Lg82m3MYjVQ)
      - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-1 (Ny3ix_6TSCelSSkX34LRQQ)

  • toolkit/components/pdfjs/test/browser_pdfjs_zoom.js

    • 2 of 2 failed on different tasks
      - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-1 (KhQzQf2cTV-Lg82m3MYjVQ)
      - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-1 (Ny3ix_6TSCelSSkX34LRQQ)

Known Issues (From Taskcluster):

  • test-windows11-64-2009-qr/opt-mochitest-browser-chrome-1 (dC40FRcIQES8vfAWrrEylQ) - new failure not classified
  • test-macosx1015-64-qr/opt-mochitest-browser-chrome-1 (HBPdU3P8TGWtnenTUc1QZw) - new failure not classified
  • test-windows11-64-2009-qr/debug-mochitest-browser-chrome-swr-1 (cWh31vy8Tc6YR36w9FpB0A) - new failure not classified
  • test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-1 (KhQzQf2cTV-Lg82m3MYjVQ) - new failure not classified
  • test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-1 (Ny3ix_6TSCelSSkX34LRQQ) - new failure not classified
  • test-windows11-64-2009-qr/debug-mochitest-browser-chrome-1 (P2p2ReAqShKc2ayU5mgqug) - new failure not classified
  • test-windows11-64-2009-qr/debug-mochitest-browser-chrome-spi-nw-1 (YylXsLN2TIiUwy-cOohrEw) - new failure not classified
  • test-macosx1015-64-qr/debug-mochitest-browser-chrome-1 (Hp2i4hMETpGceZH62LmQiA) - new failure not classified
  • test-macosx1015-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (Mo-5djnxS8ewFkudxl7pTg) - new failure not classified
  • test-windows11-64-2009-qr/opt-mochitest-browser-chrome-msix-1 (XZ9RLiEtT8u57h0jNJMUZA) - new failure not classified
  • test-linux1804-64-qr/debug-mochitest-browser-chrome-swr-1 (TUcRmSuVQUmAY1P4viNFxg) - new failure not classified
  • test-windows11-32-2009-qr/debug-mochitest-browser-chrome-1 (fGiuXeSPQluTa2viwSCcRg) - new failure not classified
  • test-windows11-32-2009-qr/opt-mochitest-browser-chrome-1 (dnRxGue_RDKmxPuDdhAZXA) - new failure not classified
  • test-windows11-64-2009-qr/debug-mochitest-browser-chrome-msix-1 (VSo_uAmAR1yLKtjZ6s65-g) - new failure not classified
  • test-windows11-64-2009-qr/opt-mochitest-browser-chrome-spi-nw-1 (aeiINNzXSTehVTsONuhoQw) - new failure not classified
  • test-linux1804-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (JoXA6vBhRruzxtECZ8nTRA) - new failure not classified

Needs Investigation (From Push Health):

  • toolkit/components/pdfjs/test/browser_pdfjs_navigation.js

    • 12 of 12 failed on different tasks
      - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-swr-1 (cWh31vy8Tc6YR36w9FpB0A)
      - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-1 (P2p2ReAqShKc2ayU5mgqug)
      - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-spi-nw-1 (YylXsLN2TIiUwy-cOohrEw)
      - test-macosx1015-64-qr/debug-mochitest-browser-chrome-1 (Hp2i4hMETpGceZH62LmQiA)
      - test-macosx1015-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (Mo-5djnxS8ewFkudxl7pTg)
      - test-windows11-32-2009-qr/debug-mochitest-browser-chrome-1 (fGiuXeSPQluTa2viwSCcRg)
      - test-windows11-32-2009-qr/opt-mochitest-browser-chrome-1 (dnRxGue_RDKmxPuDdhAZXA)
      - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-msix-1 (VSo_uAmAR1yLKtjZ6s65-g)
      - test-windows11-64-2009-qr/opt-mochitest-browser-chrome-spi-nw-1 (aeiINNzXSTehVTsONuhoQw)
      - test-windows11-64-2009-qr/opt-mochitest-browser-chrome-1 (dC40FRcIQES8vfAWrrEylQ)
      - test-linux1804-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (JoXA6vBhRruzxtECZ8nTRA)
      - test-macosx1015-64-qr/opt-mochitest-browser-chrome-1 (HBPdU3P8TGWtnenTUc1QZw)

  • toolkit/components/pdfjs/test/browser_pdfjs_zoom.js

    • 11 of 11 failed on different tasks
      - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-swr-1 (cWh31vy8Tc6YR36w9FpB0A)
      - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-1 (P2p2ReAqShKc2ayU5mgqug)
      - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-spi-nw-1 (YylXsLN2TIiUwy-cOohrEw)
      - test-macosx1015-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (Mo-5djnxS8ewFkudxl7pTg)
      - test-windows11-32-2009-qr/debug-mochitest-browser-chrome-1 (fGiuXeSPQluTa2viwSCcRg)
      - test-windows11-32-2009-qr/opt-mochitest-browser-chrome-1 (dnRxGue_RDKmxPuDdhAZXA)
      - test-windows11-64-2009-qr/debug-mochitest-browser-chrome-msix-1 (VSo_uAmAR1yLKtjZ6s65-g)
      - test-windows11-64-2009-qr/opt-mochitest-browser-chrome-1 (dC40FRcIQES8vfAWrrEylQ)
      - test-linux1804-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (JoXA6vBhRruzxtECZ8nTRA)
      - test-linux1804-64-qr/debug-mochitest-browser-chrome-swr-1 (TUcRmSuVQUmAY1P4viNFxg)
      - test-windows11-64-2009-qr/opt-mochitest-browser-chrome-msix-1 (XZ9RLiEtT8u57h0jNJMUZA)

Needs Investigation (Other Failed Jobs):

  • test-windows11-64-2009-qr/debug-test-verify
    • 4 of 4 failed on the same (retriggered) task (aR_6bk0wS064RwWhSn2EKA, IWMob_6sSmqbcQKWZ5P4mg, JeX-BieOSaC9TSjvD08f1w, VvhGGrriSGKEb5-hPo9OzA)
  • test-windows11-32-2009-qr/opt-test-verify
    • 4 of 4 failed on the same (retriggered) task (DKWUHH00SuW6a2EMilSNpg, MG3oZNyoRSS7yxdagWoM0g, UHOnqWLkSZOrL950r4lwKA, O2KcKAaKQN26WihCUNmu_w)
  • test-windows11-64-2009-qr/opt-test-verify
    • 4 of 4 failed on the same (retriggered) task (KgEp3iijTbyL3rhAx0m84A, SrkCzXlbSuqwM3dqKO-_eA, UoDG_g0FR--7cgD3ghZzfQ, ctskIT1pTNKWSqRU-_FACw)
  • test-macosx1015-64-qr/opt-test-verify
    • 4 of 4 failed on the same (retriggered) task (U_Ko-xDXSeORRgxhtK2rxA, OYJ3C2wPTZSBZNie2uKCeA, b3itY_mMTriIfoBFJeMCag, dgwbiNIdSJ6cwThbySlmNg)
  • test-macosx1015-64-qr/debug-test-verify
    • 4 of 4 failed on the same (retriggered) task (K_wrg84PR5e7rDbPxNpqAw, LacPGZWoSb2L3GdVu6CAAA, WPTlp_1nQXiLNfhFiSeCCw, fXGJLySiSYWJVCFGA6yIqA)
  • test-windows11-32-2009-qr/debug-test-verify
    • 4 of 4 failed on the same (retriggered) task (LTrXEeTlQDqHEKw5_qoe8w, RY-2vi3VRteh5K1IYRFQAA, ckr9BAO5RA-VrHkydJv5og, VbM5MyZvTZqKVpzuAt74HQ)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor toolkit/components/pdfjs/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Attachment #9392492 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: