1886786 - [wpt-sync] Sync PR 45253 - Fix non-hue channel keyword values for hsl() and hwb()

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45253 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45253
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Fix non-hue channel keyword values for hsl() and hwb()

SL and WB are stored in blink::Color in range [0 1] range, while the
[0 100] range is expected. Adjust these parameters when setting up the
channel keywords. Make sure that all values - independent of type -
are adjusted in MakePerColorSpaceAdjustments() before writing into the
destination blink::Color.

Some testcases expected an alpha value of 1 to be serialized, and one
had a space too many. Fix those up.

Bug: 330096624
Change-Id: I3b3983d73153b035687a262dae9187afea626e6d

Reviewed-on: https://chromium-review.googlesource.com/5383086
WPT-Export-Revision: e925a41d308e9eac31ad4213e2c5ed7f99747da4

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd6a77b6ed1dbece2f7bcf1bc3aa8b96d6f5fb6f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1076 subtests

## Status Summary

### Firefox
`OK`  : 2
`PASS`: 12
`FAIL`: 2075

### Chrome
`OK`  : 2
`PASS`: 1866
`FAIL`: 221

### Safari
`OK`  : 2
`PASS`: 1466
`FAIL`: 621

## Links
[GitHub PR Head](https://wpt.fyi/results/?sha=bd7b999a865dcd08014b4cdc879868486eea026a&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=bd7b999a865dcd08014b4cdc879868486eea026a&label=pr_base)

## Details

(See attachment for full changes)

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1076 subtests

## Status Summary

### Firefox
`OK`  : 2
`PASS`: 12
`FAIL`: 2075

### Chrome
`OK`  : 2
`PASS`: 1866
`FAIL`: 221

### Safari
`OK`  : 2
`PASS`: 1466
`FAIL`: 621

## Links
[GitHub PR Head](https://wpt.fyi/results/?sha=bd7b999a865dcd08014b4cdc879868486eea026a&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=bd7b999a865dcd08014b4cdc879868486eea026a&label=pr_base)

## Details

(See attachment for full changes)

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1076 subtests

## Status Summary

### Firefox
`OK`  : 2
`PASS`: 12
`FAIL`: 2075

### Chrome
`OK`  : 2
`PASS`: 1866
`FAIL`: 221

### Safari
`OK`  : 2
`PASS`: 1466
`FAIL`: 621

## Links
[GitHub PR Head](https://wpt.fyi/results/?sha=bd7b999a865dcd08014b4cdc879868486eea026a&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=bd7b999a865dcd08014b4cdc879868486eea026a&label=pr_base)

## Details

(See attachment for full changes)

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1076 subtests

## Status Summary

### Firefox
`OK`  : 2
`PASS`: 12
`FAIL`: 2075

### Chrome
`OK`  : 2
`PASS`: 1866
`FAIL`: 221

### Safari
`OK`  : 2
`PASS`: 1466
`FAIL`: 621

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd6a77b6ed1dbece2f7bcf1bc3aa8b96d6f5fb6f)
[GitHub PR Head](https://wpt.fyi/results/?sha=bd7b999a865dcd08014b4cdc879868486eea026a&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=bd7b999a865dcd08014b4cdc879868486eea026a&label=pr_base)

## Details

(See attachment for full changes)

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1076 subtests

## Status Summary

### Firefox
`OK`  : 2
`PASS`: 12
`FAIL`: 2075

### Chrome
`OK`  : 2
`PASS`: 1866
`FAIL`: 221

### Safari
`OK`  : 2
`PASS`: 1466
`FAIL`: 621

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd6a77b6ed1dbece2f7bcf1bc3aa8b96d6f5fb6f)
[GitHub PR Head](https://wpt.fyi/results/?sha=bd7b999a865dcd08014b4cdc879868486eea026a&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=bd7b999a865dcd08014b4cdc879868486eea026a&label=pr_base)

## Details

(See attachment for full changes)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb2fb8830e11
[wpt PR 45253] - Fix non-hue channel keyword values for hsl() and hwb(), a=testonly

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1076 subtests

## Status Summary

### Firefox
`OK`  : 2
`PASS`: 12
`FAIL`: 2075

### Chrome
`OK`  : 2
`PASS`: 1866
`FAIL`: 221

### Safari
`OK`  : 2
`PASS`: 1466
`FAIL`: 621

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd6a77b6ed1dbece2f7bcf1bc3aa8b96d6f5fb6f)
[GitHub PR Head](https://wpt.fyi/results/?sha=bd7b999a865dcd08014b4cdc879868486eea026a&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=bd7b999a865dcd08014b4cdc879868486eea026a&label=pr_base)

## Details

(See attachment for full changes)

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bb2fb8830e11