1886839 - Missing context menu (for e.g. "open image in new tab") for new Firefox Screenshots backend

Status: ASSIGNED

(Firefox :: Screenshots, defect, P2)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Start Firefox Nightly (with screenshots.browser.component.enabled set to true as it is by default now, as of bug 1789727)
2. Right-click some page and choose "Take Screenshot"
3. Choose "Save Full Page"
4. Right-click the full-page-screenshot image, with the intent of choosing "Open in new tab".

ACTUAL RESULTS:
No context menu appears for the screenshot.

EXPECTED RESULTS:
Maybe/probably a context-menu should appear?

Current Nightly 126.0a1 (2024-03-21) gives ACTUAL RESULTS.
Release versions give EXPECTED RESULTS.

Really, release and Nightly both give ACTUAL RESULTS if screenshots.browser.component.enabled is set to true, and they both give EXPECTED RESULTS if it's set to false. So in Nightly, this was a regression from bug 1789727 which is where we set that pref to true, but I think that pref is only enabled for Nightly configurations right now, so other release channels are unaffected at this point/

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screencast showing the context menu appearing (expected results) when the pref is `false`, and not-appearing (actual results) when the pref is `true`

Comment 2

[Daniel Holbert [:dholbert]]

In the attached screencast, the EXPECTED RESULTS are shown at time t=7s (with the pref disabled), and the ACTUAL RESULTS are shown at t=19s (you'll have to take my word for it that I'm right-clicking the image at that point).

Comment 3

[Jonathan Watt [:jwatt]]

The "Open Image in New Tab" context menu item is useful as part of a workaround workflow for users that want to print "what they see on the screen" instead of printing using our normal paginated print output.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:niklas, since you are the author of the regressor, bug 1789727, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 5

[Pascal Chevrel:pascalc]

Sam, will this be fixed when we ship the new backend to release? Thanks

Comment 6

[Sam Foster [:sfoster] (he/him)]

(In reply to Pascal Chevrel:pascalc from comment #5)

Sam, will this be fixed when we ship the new backend to release? Thanks

I'm not sure. We haven't identified a fix yet. I think if necessary I would be ok shipping without it, but I'd like to get a fix in if possible.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox127 (nightly). We have limited time to fix this, the soft freeze is in 3 days. However, the bug still isn't assigned and has low severity.

:pluk, could you please find an assignee and increase the severity for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 8

[Haik Aftandilian [:haik]]

@Niklas, can you say if this will make 128?

Comment 10

[Donal Meehan [:dmeehan]]

:niklas, the Fx129 soft code freeze starts on Thursday 2024-07-04, ahead of Fx129 merging to beta on Monday 2024-07-08.
Do you plan on fixing this in time for Fx129?

Comment 11

[Sam Foster [:sfoster] (he/him)]

(In reply to Donal Meehan [:dmeehan] from comment #10)

:niklas, the Fx129 soft code freeze starts on Thursday 2024-07-04, ahead of Fx129 merging to beta on Monday 2024-07-08.
Do you plan on fixing this in time for Fx129?

I don't think we can target a specific release for this. We haven't identified a solution yet and higher priority projects/components are taking up the teams time for short-term.

As it stands the context menu mechanism we normally use is not really compatible for this use case where the image is inside a tab dialog. So most of the work is in first refactoring our context menu code. If anyone is able to move this forward I'd be happy to review a patch or tag team on a patch.