Bug 1356686 causes compile time failure of nsStreamConverter::MaybeRetarget in comm/mailnews/mime/srcnsStreamConverter.cpp
Categories
(MailNews Core :: MIME, defect)
Tracking
(Not tracked)
People
(Reporter: ishikawa, Unassigned)
Details
The local build error.
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/mime/src/nsStreamConverter.cpp:967:1: error: no declaration matches ‘nsresult nsStreamConverter::MaybeRetarget(nsIRequest*)’
967 | nsStreamConverter::MaybeRetarget(nsIRequest* request) {
| ^~~~~~~~~~~~~~~~~
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/mime/src/nsStreamConverter.cpp:967:1: note: no functions named ‘nsresult nsStreamConverter::MaybeRetarget(nsIRequest*)’
In file included from /NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/mime/src/nsStreamConverter.cpp:10:
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/mailnews/mime/src/nsStreamConverter.h:20:7: note: ‘class nsStreamConverter’ defined here
20 | class nsStreamConverter : public nsIStreamConverter,
| ^~~~~~~~~~~~~~~~~
Actually, I am not sure if the Bug 1356686 is the sole culprit.
But searchfox says "MaybeRetarget" is found here, and it has been modified on March 19, 2024.
https://searchfox.org/mozilla-central/source/netwerk/streamconv/nsIStreamConverter.idl#102
So it seems a smoking gun.
I have tried to refresh my local source tree in the last hour or so, and still no go.
|
||
Comment 1•2 years ago
|
||
Please pull latest m-c.
You can always check if tip is ok by looking at https://treeherder.mozilla.org/jobs?repo=comm-central
|
Reporter | |
Comment 2•2 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #1)
Please pull latest m-c.
You can always check if tip is ok by looking at https://treeherder.mozilla.org/jobs?repo=comm-central*** This bug has been marked as a duplicate of bug 1886328 ***
Thank you for the tips.
So it has been taken care of.
During my trials and errors, I tried updating the source tree a few times. But still no go.
Maybe the source tree did not have the patch in place yet when I tried.
Description
•