1886964 - NVDA does not read the Highlight floating button when hovered over with the mouse cursor

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Rares Doghi, Desktop QA]

Found in

• 126.0a1 (2024-03-21)

Affected versions

• 126.0a1 (2024-03-21)
• Beta 125.0b3

Affected platforms

• ALL

Preconditions:
pdfjs.enableHighlightEditor - true
pdfjs.enableHighlightFloatingButton - true
Enable NVDA.

Steps to reproduce

1. Have a PDF opened in Firefox.
2. Select any text.
3. Hover the mouse cursor over the Highlight Floating button.

Expected result

• The FLoating button should be read out loud by NVDA

Actual result

• The Highlight Floating button is not read by the NVDA.

Regression range
Not a Regression

Comment 1

[Calixte Denizet (:calixte)]

I think it's a NVDA issue:
https://github.com/nvaccess/nvda/issues/12047
That said we can workaround it in adding an invisible span in the button.

Comment 2

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Add a label to the highight floating button readable with NVDA (bug 1886964) (#17825)

Comment 3

[Anna Yeddi [:ayeddi]]

Attachment: Accessibility Inspector results for the button and options

Since these buttons do not have any visible text always, NVDA mouse tracking will not read the text, which is a known issue with NVDA mouse tracking.

The options are rendered as expected in the Accessibility tree (refer to the screenshot attached), with an informative labels. So the lack of on-hover announcement, in this case, is the NVDA bug.

What we could do is to add an on-screen text next to color option circles, so there is an on-screen text (that is included in the option markup) - this should be announced by the NVDA.

I'll triage it as access-s4 since this is not a delightful pattern in any case, but yet the issue is not as severe and is largely dependent on the assistive technology software, unless we'll change the visual appearance - or use the hack that Calixte has offered (thank you!).

The same approach could be applied to the bug 1886963 and bug 1886961 too

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build.

Comment 6

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta build 125.0b8