1887529 - "More Translation Settings" expanding for a split second when opening about:preferences for the first time within the same session

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[aoia7rz7l]

Tested on 125.0b1 and b3.

STR:

1. Close all Firefox windows and start Firefox in a new session.
2. Open about:preferences.

Expected Behavior:

Nothing remarkable happens.

Actual Behavior:

Something can be seen expanding for a split second when I opened about:preferences for the first time within the same session. A quick printscreen revealed strings such as:

More Translation Settings

Set you language and site translation preferences and manage languages downloaded of offline translation.

Always translate these languages [Add language]
Never translate these languages [Add language]
Never translate these sites
Download languages

This is not 100% reproducible but I would say about two thirds of the time. Setting browser.translations.enable or browser.translations.newSettingsUI.enable to false (or both) does not seem to affect the issue.

Mozregression returned

Last good revision: 9793d58574ba0c44dd7cea68fdbac2405ccaa693
First bad revision: 39d76f98160905dab2a294ece0e03ee8ba5ba4cc
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9793d58574ba0c44dd7cea68fdbac2405ccaa693&tochange=39d76f98160905dab2a294ece0e03ee8ba5ba4cc

Oh and what's with the UI inconsistency in about:preferences these days? First Firefox Sugeest decided they needed to use toogles instead of checkboxes, and now Firefox Translations implemented another layer of settings that looks like something straight out of mobile OSes/Chrome desktop? IMO you should have split this into a #translations section like about:preferences#search instead of the current approach, assuming that your problem is that the dialog/modal is too small for your needs.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Setting Regressed by field after analyzing regression range found by mozregression in comment #0.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:colorcodedcrayons, since you are the author of the regressor, bug 1872860, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Meera Murthy]

I've been working on reproducing the issue but haven't succeeded so far. However, we've identified a possible reason. It seems that some HTML code that should be hidden is displaying due to a missing 'hidden' attribute in the translations setting HTML.
We shall fix this issue as soon as possible.

Comment 4

[Meera Murthy]

Attachment: Bug 1887529 - [translations] Translations Setting page showing up when about:preferences is opened for the first time.

Comment 5

[Erik Nordin [:nordzilla]]

Oh and what's with the UI inconsistency in about:preferences these days? First Firefox Sugeest decided they needed to use toogles instead of checkboxes, and now Firefox Translations implemented another layer of settings that looks like something straight out of mobile OSes/Chrome desktop?

I can't speak to Firefox Suggest, but the designs for the new Translations Settings came from the UX team, and they look nice to me. I think moving to a sub page looks better than the pop-up dialog.

IMO you should have split this into a #translations section like about:preferences#search instead of the current approach, assuming that your problem is that the dialog/modal is too small for your needs.

This will be a sub-page about:preferences#translations, but the point of access will be from the Language and Translation section of the general pane.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1872860

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6f6604fe051
[translations] Translations Setting page showing up when about:preferences is opened for the first time.  r=nordzilla,settings-reviewers,Gijs

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c6f6604fe051

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:colorcodedcrayons, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Erik Nordin [:nordzilla]]

Attachment: Bug 1887529 - [translations] Translations Setting page showing up when about:preferences is opened for the first time.

Original Revision: https://phabricator.services.mozilla.com/D205815

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/9299718e0a8e

Comment 12

[aoia7rz7l]

I can confirm that the STR in comment 0 is reproducible in 125.0b8, but not in 125.0b9 on Windows 10.

Comment 13

[Meera Murthy]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #9)

The patch landed in nightly and beta is affected.
:colorcodedcrayons, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

The uplift has already landed.

Comment 14

[Meera Murthy]

The uplift has already landed.