1887606 - text alignment of buttons in crash reporter is no longer correct

Status: VERIFIED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Sören Hentzschel]

I didn't test myself on Windows and macOS, but the screenshots in the reports of :gregp show that the text in the buttons is no longer correctly vertically aligned on Linux, see for example the screenshot in bug 1887502 - there is more empty space below the text than above now.

Comment 1

[BugBot [:suhaib / :marco]]

:afranchuk, since you are the author of the regressor, bug 1759175, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Alex Franchuk [:afranchuk]]

Good point. Also the buttons aren't the same width (it looks nicer if they are). Not sure why the vertical alignment is off (it's just a default button after all), but it's likely easy to fix. I doubt this will carry over to macOS/windows, but I will check them all the same.

Comment 3

[Alex Franchuk [:afranchuk]]

On my local system the buttons don't have that odd vertical alignment (which is probably why I didn't notice it and fix it earlier). I suspect it has to do with the GTK theme in use. I still think it may be easy to fix (setting layout properties).

Comment 4

[Gregory Pappas [:gregp]]

FWIW, I am using GNOME / Adwaita on Fedora 39 on a 1920x1080 display at 1x scale.

Comment 5

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1887606 - Fix the text alignment of buttons in the crash reporter r=gsvelto

This fixes the alignment on linux. On windows and macOS, due to the
implementation specializing this case, there is no difference in
alignment. This also sets a fixed, identical width for both buttons to
be more visually appealing (on all platforms).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a8e71d797b1
Fix the text alignment of buttons in the crash reporter r=gsvelto

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7a8e71d797b1

Comment 8

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue on an affected Firefox Nightly build 126.0.a1 (2024-03-23), using Ubuntu 22.04. On macOS and Windows I was not able to reproduce it.
Verified as fixed on Firefox 126.0b5, build ID 20240424091756, using Ubuntu 22.04. Vertical alignment of buttons in crash reporter dialog is now correct.
I have also verified that the width for both buttons is 160px on Ubuntu 22.04, Windows 11 and macOS 12.6.6.