1887656 - macOS "rusty" build-signing jobs fail in CI

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

build-signing-macosx64-rust/opt fails with KeyError: 'entitlements-url'

Made visible by bug 1886051, but it's always been broken probably.

https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=VOXCDsz_RqqwmCMhqEFBVA.0

2024-03-25 11:26:09,854 - scriptworker_client.client - DEBUG - Task is verified against this schema: {'title': 'Taskcluster signing task minimal schema', 'type': 'object', 'properties': {'dependencies': {'type': 'array', 'minItems': 1, 'uniqueItems': True, 'items': {'type': 'string'}}, 'scopes': {'type': 'array', 'minItems': 1, 'uniqueItems': True, 'items': {'type': 'string'}}, 'payload': {'type': 'object', 'properties': {'upstreamArtifacts': {'type': 'array', 'items': {'type': 'object', 'properties': {'taskType': {'type': 'string'}, 'taskId': {'type': 'string'}, 'formats': {'type': 'array', 'uniqueItems': True, 'items': {'type': 'string', 'enum': ['macapp', 'widevine', 'omnija', 'autograph_widevine', 'autograph_omnija', 'mac_geckodriver', 'mac_single_file', 'autograph_langpack']}}, 'paths': {'type': 'array', 'minItems': 1, 'uniqueItems': True, 'items': {'type': 'string'}}}, 'singleFileGlobs': {'type': 'array', 'uniqueItems': True, 'items': {'type': 'string'}}, 'required': ['taskId', 'taskType', 'paths']}, 'minItems': 1, 'uniqueItems': True}, 'behavior': {'type': 'string', 'enum': ['mac_notarize', 'mac_geckodriver', 'mac_sign', 'mac_sign_hardened', 'mac_sign_and_pkg_hardened', 'mac_sign_and_pkg', 'mac_notarize_part_1', 'mac_notarize_part_3', 'mac_single_file', 'mac_notarize_vpn', 'mac_sign_and_pkg_vpn', 'mac_notarize_single_file', 'mac_notarize_geckodriver']}, 'product': {'type': 'string', 'enum': ['firefox', 'mozillavpn', 'mozregression']}, 'entitlements-url': {'type': 'string'}, 'hardened-sign-config': {'type': 'array', 'minItems': 0, 'uniqueItems': True, 'items': {'type': 'object', 'properties': {'deep': {'type': 'boolean'}, 'runtime': {'type': 'boolean'}, 'force': {'type': 'boolean'}, 'entitlements': {'type': 'string'}, 'globs': {'type': 'array', 'minItems': 1, 'items': {'type': 'string'}}}}}, 'provisioning-profile-config': {'type': 'array', 'minItems': 0, 'uniqueItems': True, 'items': {'type': 'object', 'properties': {'profile_name': {'description': 'Filename of profile in the workers.', 'type': 'string'}, 'target_path': {'description': 'Relative path to add profile to.', 'type': 'string'}}}}, 'provisioning-profile-url': {'type': 'string'}, 'requirements-plist-url': {'type': 'string'}}, 'required': ['upstreamArtifacts']}}, 'required': ['scopes', 'payload']}
2024-03-25 11:26:09,873 - asyncio - DEBUG - Using selector: KqueueSelector
2024-03-25 11:26:09,873 - scriptworker_client.utils - INFO - Running ['hostname'] in / ...
2024-03-25 11:26:09,881 - scriptworker_client.utils - INFO - dep-mac-v3-signing1.srv.releng.mdc1.mozilla.com
2024-03-25 11:26:09,881 - scriptworker_client.utils - INFO - ['hostname'] in / exited 0
Traceback (most recent call last):
File "/builds/tb-dep/virtualenv/bin/iscript", line 33, in <module>
sys.exit(load_entry_point('iscript==1.0.1', 'console_scripts', 'iscript')())
File "/builds/tb-dep/virtualenv/lib/python3.8/site-packages/iscript-1.0.1-py3.8.egg/iscript/script.py", line 126, in main
return sync_main(async_main, default_config=get_default_config())
File "/builds/tb-dep/virtualenv/lib/python3.8/site-packages/scriptworker_client-1.0.0-py3.8.egg/scriptworker_client/client.py", line 123, in sync_main
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
return future.result()
File "/builds/tb-dep/virtualenv/lib/python3.8/site-packages/scriptworker_client-1.0.0-py3.8.egg/scriptworker_client/client.py", line 178, in _handle_asyncio_loop
File "/builds/tb-dep/virtualenv/lib/python3.8/site-packages/iscript-1.0.1-py3.8.egg/iscript/script.py", line 100, in async_main
await func(config, task, **args)
File "/builds/tb-dep/virtualenv/lib/python3.8/site-packages/iscript-1.0.1-py3.8.egg/iscript/mac.py", line 1390, in sign_and_pkg_behavior
entitlements_path = await download_entitlements_file(config, sign_config, task)
File "/builds/tb-dep/virtualenv/lib/python3.8/site-packages/iscript-1.0.1-py3.8.egg/iscript/mac.py", line 1132, in download_entitlements_file
url = task["payload"]["entitlements-url"]
KeyError: 'entitlements-url'
exit code: 1

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1887656 - Add macosx64-rust/opt to allowed mac-signing build platforms. r=#thunderbird-build-system-reviewers

The macOS Rust builds were falling back to the v1 macOS hardened signing configs (for
Firefox). Those were removed in bug 1886051 causing these signing jobs to fail.
Just needed to add the build platform to only-for-build-platforms so the transform picks
it up.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f1480bf9db29
Add macosx64-rust/opt to allowed mac-signing build platforms. r=rjl