188769 - Make Mozilla 1.0 start page work in Opera

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Marek Stępień [:marcoos, inactive]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl-PL; rv:1.3a) Gecko/20021212
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl-PL; rv:1.3a) Gecko/20021212

Some people informed me that they use Mozilla 1.0 start pages for evangelizing.
And some Opera users have switched to Mozilla after reading it. :)

So I thought it'be nice to change the stylesheets.js to work under Opera 7. It
needs just simple corrections.

I've already updated the stylesheets.js in the Polish translation of Moz start
pages.

Reproducible: Always

Steps to Reproduce:
1. Go to Mozilla 1.0 startpages with Opera 7.
Actual Results:  
1. See no style switcher at the bottom.

Comment 1

[Marek Stępień [:marcoos, inactive]]

Attachment: stylesheets.js - compatible with both Mozilla nad Opera :)

This is my modification of the stylesheets.js file.

Comment 2

[Gervase Markham [:gerv]]

Could you please use the Doctor (the "Edit This Page" link) to produce a diff?
Obviously, the style sheet itself doesn't have an "Edit This Page" link on it,
but it's fairly easy to hack the URL of another Doctor session.
e.g. http://doctor.mozilla.org/?file=mozilla-org/html/start/1.0/defaultstyle.css

Gerv

Comment 3

[Marek Stępień [:marcoos, inactive]]

Attachment: Results from doctor.mozilla.org

This is the whole output (from the gray field) of doctor.mozilla.org after my
changes to www.mozilla.org/start/1.0/stylesheets.js

(Note: stylesheets.js - not some *.css files :)

Comment 4

[Gervase Markham [:gerv]]

OK. Point 2: just make the changes you need to change. I can't see what's going
on here because you've put extra blank lines in loads of places. Have another go :-)

Gerv

Comment 5

[Daniel Wang]

-> moz.org

Comment 6

[Gervase Markham [:gerv]]

Marek: are you able to update your patch here?

Gerv

Comment 7

[Marek Stępień [:marcoos, inactive]]

Ok, I used doctor once again without putting new lines. The patch produced by it
 will follow this comment.

The changes are simple - removing the is_gecko checks, since any standards
compliant browser should manage to execute the code, so there's no need in
limiting access.

And this if-statement is useless:

if ( title == "Very Simple" || title == "Light Blue" || title == "Orange" )

because the script works ok without it, too. And causes that we have to modify
the script every time we add a new stylesheet. :)

Comment 8

[Marek Stępień [:marcoos, inactive]]

Attachment: patch for stylesheets.js, that should make the script work in all DOM-compliant browsers

Comment 9

[Gervase Markham [:gerv]]

Fixed.

Checking in stylesheets.js;
/cvsroot/mozilla-org/html/start/1.0/stylesheets.js,v  <--  stylesheets.js
new revision: 1.2; previous revision: 1.1
done

Gerv