1887707 - Add a herald rule for perftest-reviewers to add comment reminding us about documentation

Status: RESOLVED FIXED

(Conduit :: Phabricator, task)

Description

[Greg Mierzwinski [:sparky]]

On the perftest team, we'd like to get a reminder to check if documentation needs to be updated or created whenever a patch has the #perftest-reviewers on it.

Could a new herald rule be added to make a comment on those patches automatically? This comment should be enough for us to start:

You've pushed a patch that is making changes in areas of Performance Testing.

Please ensure that all the documentation related to this change is updated. Additionally, please ensure that documentation is added for any new features, workarounds, or enhancements.

You can find the existing documentation for Performance Testing here: https://firefox-source-docs.mozilla.org/testing/perfdocs/

I'd like the last line to appear like so but I'm not sure if this formatting is available in the comments: You can find the existing documentation for Performance Testing here.

Comment 1

[David Lawrence [:dkl]]

https://phabricator.services.mozilla.com/H431

Comment 2

[Greg Mierzwinski [:sparky]]

Thanks for looking into this so quickly :dkl! However, I tried out a couple test patches but neither of them seem to be generating the comment. Here's one of the patches: https://phabricator.services.mozilla.com/D205636

I looked at the herald transcript, and found that it was failing on the condition:

H431 Comment for perftest-reviewers
Conditions	
Failed	Repository projects include all of perftest-reviewers
Failed	Not all conditions matched.

It should have triggered on this patch since it's blocked by the #perftest-reviewers review group.

Here's a link directly to the transcript: https://phabricator.services.mozilla.com/herald/transcript/7429757/

Comment 3

[David Lawrence [:dkl]]

(In reply to Greg Mierzwinski [:sparky] from comment #2)

Thanks for looking into this so quickly :dkl! However, I tried out a couple test patches but neither of them seem to be generating the comment. Here's one of the patches: https://phabricator.services.mozilla.com/D205636

I looked at the herald transcript, and found that it was failing on the condition:

H431 Comment for perftest-reviewers
Conditions	
Failed	Repository projects include all of perftest-reviewers
Failed	Not all conditions matched.

It should have triggered on this patch since it's blocked by the #perftest-reviewers review group.

Here's a link directly to the transcript: https://phabricator.services.mozilla.com/herald/transcript/7429757/

My fault. I mistakenly chose "Repository projects include all of" Instead of "Reviewers include any of:. I have updated the rule now. Lets see if the next one works.

Comment 4

[Greg Mierzwinski [:sparky]]

Thanks for fixing that up, and quickly implementing this herald rule :dkl! I'm seeing the comment now: https://phabricator.services.mozilla.com/D205645