1887782 - [UIA] Implement ScrollItem control pattern

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

The ScrollItem pattern allows a client to scroll an element into view.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1887782: Implement the UIA ScrollItem pattern.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dd2d24044af
Implement the UIA ScrollItem pattern. r=nlapre

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bustage on uiaRawElmProvider.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/e9a6b1d9b2360abbda7261a5e023f1fdfaf1fbc4
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=JulcT_JCRTiWuSnBXGl3mQ.0&revision=2dd2d24044af0a4a84da92087ec839d5df0144b9
• failure log: https://treeherder.mozilla.org/logviewer?job_id=453277821&repo=autoland&lineNumber=13744

[task 2024-04-03T01:34:11.718Z] 01:34:11     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang-cl -fms-compatibility-version=19.39 -Xclang -std=c++17 -Xclang -ivfsoverlay -Xclang /builds/worker/fetches/vs/overlay.yaml -FouiaRawElmProvider.obj -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -guard:cf -D_FORTIFY_SOURCE=0 -Xclang -fno-common -DNDEBUG=1 -DTRIMMED=1 -DUNICODE -D_UNICODE -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/accessible/windows/uia -I/builds/worker/workspace/obj-build/accessible/windows/uia -I/builds/worker/checkouts/gecko/accessible/base -I/builds/worker/checkouts/gecko/accessible/generic -I/builds/worker/checkouts/gecko/accessible/html -I/builds/worker/checkouts/gecko/accessible/windows/msaa -I/builds/worker/checkouts/gecko/accessible/xpcom -I/builds/worker/checkouts/gecko/accessible/xul -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -MD -FI /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -fsanitize=address -fsanitize-blacklist=/builds/worker/checkouts/gecko/build/sanitizers/asan_blacklist_win.txt -fcrash-diagnostics-dir=/builds/worker/artifacts -fcrash-diagnostics-dir=/builds/worker/artifacts -fcrash-diagnostics-dir=/builds/worker/artifacts -TP -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -Gy -Zc:inline -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -Oy- -Werror -W3 -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wvolatile -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-microsoft-exception-spec -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -fno-strict-aliasing -Xclang -ffp-contract=off  -Xclang -MP -Xclang -dependency-file -Xclang .deps/uiaRawElmProvider.obj.pp -Xclang -MT -Xclang uiaRawElmProvider.obj   /builds/worker/checkouts/gecko/accessible/windows/uia/uiaRawElmProvider.cpp
[task 2024-04-03T01:34:11.726Z] 01:34:11    ERROR -  /builds/worker/checkouts/gecko/accessible/windows/uia/uiaRawElmProvider.cpp(667,3): error: functions marked as MOZ_CAN_RUN_SCRIPT can only be called from functions also marked as MOZ_CAN_RUN_SCRIPT
[task 2024-04-03T01:34:11.727Z] 01:34:11     INFO -    667 |   acc->ScrollTo(nsIAccessibleScrollType::SCROLL_TYPE_ANYWHERE);
[task 2024-04-03T01:34:11.727Z] 01:34:11     INFO -        |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-04-03T01:34:11.727Z] 01:34:11     INFO -  /builds/worker/checkouts/gecko/accessible/windows/uia/uiaRawElmProvider.h(108,37): note: caller function declared here
[task 2024-04-03T01:34:11.727Z] 01:34:11     INFO -    108 |   virtual HRESULT STDMETHODCALLTYPE ScrollIntoView(void);
[task 2024-04-03T01:34:11.727Z] 01:34:11     INFO -        |                                     ^
[task 2024-04-03T01:34:11.728Z] 01:34:11     INFO -  1 error generated.
[task 2024-04-03T01:34:11.728Z] 01:34:11    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:688: uiaRawElmProvider.obj] Error 1
[task 2024-04-03T01:34:11.728Z] 01:34:11     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/accessible/windows/uia'
[task 2024-04-03T01:34:11.728Z] 01:34:11     INFO -  gmake[4]: Target 'target-objects' not remade because of errors.
[task 2024-04-03T01:34:11.729Z] 01:34:11    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: accessible/windows/uia/target-objects] Error 2

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96b1f26b3790
Implement the UIA ScrollItem pattern. r=nlapre

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/96b1f26b3790