1887872 - Apply previous breakpoints on toolbox opening instead of only when the debugger is opened

Status: ASSIGNED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau]]

For now, the breakpoints are only restored when the debugger is opened.
It means that if you used to set a breakpoint, close and reopen devtools on the inspector or console (or any panel other than the debugger),
the breakpoints are not going to be functional. Only debugger statement would work... which is surprising.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1887872 - [devtools] Set breakpoints on toolbox opening.

Register them as soon as we open devtools, instead of waiting for debugger panel opening.
So that breakpoints can work even if we did not open debugger panel yet.
So far, only debugger statement would force the opening of the debugger.

This allows to remove the redundant code from debugger frontend.

Also clarify in this patch that thread-utils exports thread configurations.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1887872 - [devtools] Set event breakpoints on toolbox opening.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/705494857aed
[devtools] Set breakpoints on toolbox opening. r=devtools-reviewers,devtools-backward-compat-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/b32b818f2175
[devtools] Set event breakpoints on toolbox opening. r=devtools-reviewers,bomsy

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing dt failures on browser_dbg-old-breakpoint.js

Backout link

Push with failures

Failure log

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:ochameau, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 6

[Hubert Boma Manilla (:bomsy)]

Deferring to Alex on this, there might be some backout fixes

Comment 7

[Alexandre Poirot [:ochameau]]

See https://phabricator.services.mozilla.com/D205772#7071614