Closed Bug 1887910 Opened 10 months ago Closed 10 months ago

[wpt-sync] Sync PR 45316 - Remove the '_' hack to remove variant names from filename

Categories

(Core :: Graphics: Canvas2D, task, P4)

task

Tracking

()

RESOLVED FIXED
126 Branch
Tracking Status
firefox126 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45316 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45316
Details from upstream follow.

Jean-Philippe Gravel <jpgravel@chromium.org> wrote:

Remove the '_' hack to remove variant names from filename

For some variants, we do not want to automatically insert the variant
names in the generated filename. This used to be done by prefixing the
variant names with ''. Later, an 'append_variants_to_name' param was
added. This is cleaner and more explicit and we should get rid of the
'
' hack in favor of this new param.

Bug: 330885075
Change-Id: Ibcded647146945ecea60bea5e3d76747c338f1aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5377283
Reviewed-by: Andres Ricardo Perez \<andresrperez@chromium.org>
Commit-Queue: Jean-Philippe Gravel \<jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1277613}

PR 45316 applied with additional changes from upstream: 2f5c20b828d3736df17482351253170b42b8b028, efd5dd834256a0a81bdec002082b12d92b3cf201, d70b872f3708e8883a876d73ff7ccc2ae5e24cbd, b299e51da8eb680b4dae066ca2d69206b4930be3
Component: web-platform-tests → Graphics: Canvas2D
Product: Testing → Core
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b85e13b63cc8 [wpt PR 45316] - Remove the '_' hack to remove variant names from filename, a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.