1887934 - [wpt-sync] Sync PR 45324 - [FedCM] Fix the implementation of test_driver.get_fedcm_dialog_title

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45324 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45324
Details from upstream follow.

Christian Biesinger <[e-mail]> wrote:

[FedCM] Fix the implementation of test_driver.get_fedcm_dialog_title

It is supposed to return a dictionary:
https://fedidcg.github.io/FedCM/#webdriver-gettitle

This was causing the test to fail when run against "real"
webdriver:
https://wpt.fyi/results/credential-management/fedcm-context.https.html?label=experimental&label=master

R=[e-mail]

Bug: 331237776
Change-Id: I25168e475cd15b93e3fb4f175ec697ab5b027023
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5394270
Reviewed-by: Nicolás Peña \<[e-mail]>
Commit-Queue: Christian Biesinger \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1277980}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f49651807681874d8844f57084d0e021caddec59

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

TIMEOUT: 2
NOTRUN : 3

Chrome

TIMEOUT: 2
NOTRUN : 3

Safari

TIMEOUT: 1
ERROR : 1
NOTRUN : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /credential-management/fedcm-context.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: ERROR)
  • FedCM call defaults to 'signin' context.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • FedCM with 'signup' context.: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
  • FedCM with 'use' context.: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
  • FedCM with 'continue' context.: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)

Tests Disabled in Gecko Infrastructure

• /credential-management/fedcm-context.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ced5b62c5d11
[wpt PR 45324] - [FedCM] Fix the implementation of test_driver.get_fedcm_dialog_title, a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ced5b62c5d11