1887947 - [wpt-sync] Sync PR 45333 - Revert "[Invokers] Only dispatch invoke for built-ins or actions containing '-'"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45333 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45333
Details from upstream follow.

Matt Reynolds <[e-mail]> wrote:

Revert "[Invokers] Only dispatch invoke for built-ins or actions containing '-'"

This reverts commit 87ca363c4a89ce638bb9dbfba8ad71b967e1bcbe.

Reason for revert: invoketarget-on-details-invalid-behavior.tentative.html failing on multiple builders

Original change's description:

[Invokers] Only dispatch invoke for built-ins or actions containing '-'

(This relands
https://chromium-review.googlesource.com/c/chromium/src/+/5366502 after
fixing timeout issues in
https://chromium-review.googlesource.com/c/chromium/src/+/5372478)

This change refactors the HandleInvokeInternal calls to use an enum
class of known attribute values including a kCustom key which can determine if the invoke action meets the criteria for being
a "custom" action - that is it includes a dash (see
https://github.com/whatwg/html/pull/9841/commits/b40ba866cc21553f63d8f6244becbdbc38176310).

This also updates the tests to reflect this; only actions with a -, or
otherwise known actions, will dispatch an event. All other actions do
not, and must be manually dispatched. This does not preclude web authors
from manually dispatching said events.

Bug: 40947660
Change-Id: Ie6efeac7991c449b54d0c8b7ed360501ae5c8d37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5388656
Reviewed-by: Joey Arhar \<[e-mail]>
Reviewed-by: Mason Freed \<[e-mail]>
Auto-Submit: Keith Cirkel \<[e-mail]>
Commit-Queue: Joey Arhar \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1277851}

Bug: 40947660
Change-Id: I89f4d5efaba810d345c571d558cb826b263dd907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393427
Owners-Override: Matt Reynolds \<[e-mail]>
Auto-Submit: Matt Reynolds \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Commit-Queue: Matt Reynolds \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1278027}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
PASS: 2
FAIL: 4

Chrome

OK : 1
PASS: 6

Safari

OK : 1
PASS: 2
FAIL: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html [wpt.fyi]
  • event dispatches on click: FAIL (Chrome: PASS, Safari: FAIL)
  • event action is set to invokeAction: FAIL (Chrome: PASS, Safari: FAIL)
  • event action is set to invokeaction attribute: FAIL (Chrome: PASS, Safari: FAIL)
  • event dispatches if invokee is non-HTML Element: FAIL (Chrome: PASS, Safari: FAIL)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23aee02434a9
[wpt PR 45333] - Revert "[Invokers] Only dispatch invoke for built-ins or actions containing '-'", a=testonly

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/23aee02434a9