1887956 - OPEN_ABOUT_PAGE "where" behavior between "tab" and "tabshifted" is backwards

Status: NEW

(Firefox :: Messaging System, defect, P2)

Description

[Jason Prickett]

When using the OPEN_ABOUT_PAGE special message action, the "where" parameter allows us to pass in information about where a tab should be opened, but when set either tab or tabshifted, it exhibits the expected behavior for the other.

It is implementing openTrustedLinkIn, which has a line that sets forceForeground to true if it is null. We can fix the issue by adding a third parameter to the openTrustedLinkIn call, passing in { forceForeground: false }

We should also consider using openLinkIn for this instead, since the only differences between it and openTrustedLinkIn are the trigger principle being set to the system principle if there is not a principle specified in the method call (note: we are passing in the system principle with openLinkIn in OPEN_URL), and the aforementioned setting of the forceForeground to true.

Comment 1

[Punam Dahiya [:pdahiya]]

NI Jason to clarify below questions that came up when triaging the bug
a) Can you please check if you have browser.tabs.loadInBackground pref set. By default tab should always open url in a new tab without moving focus and tabshifted should open url in a new tab taking user focus to opened tab
b) About using openTrustedLinkIn for about pages it's intentional. Are there scenarios where about pages don't need to be trusted?

Comment 2

[Shane Hughes [:aminomancer]]

We can pass the system principal if an about page is passed to OPEN_URL.