18880 - Disabled buttons remain highlighted during installation

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P3)

Description

[Eli Goldberg]

* TITLE/SUMMARY
Disabled buttons remain highlighted during installation

* STEPS TO REPRODUCE
0) Launch the Mozilla Installer
1) Proceed through the installer until you reach the "Install" button.
2) Press the "Install" button.

* RESULT
 - What happened

Neither the "Go Back" or "Install" buttons disable, despite being buttons that
the user can no longer press.

 - What was expected

I think there's a deeper question of what the user would _want_ to do at this
point --- e.g. rather than simply disable the buttons in question:

	* the MindVision VISE installer, at this point, pops up a new progress
window, with the only button being "Stop".
	* the Apple installer also pops up a new modal progress window, with the
only button being "Cancel".

* REGRESSION

 - Occurs On
        Mozilla Installer 11.15.99 build

 - Doesn't Occur On
        MindVision Installer VISE (from Communicator 4.7 installer)
        Mac OS Installer (from Mac OS 8.1)

* CONFIGURATIONS TESTED

- [Mac] Beige Power Mac G3 (266 MHz PowerPC 750), 96 MB RAM (VM on; 1 MB of VM
used), 1024x768 (Thousands of Colors), Mac OS 8.6

- [Win32] Vectra VL (233 MHz P2), 96 MB RAM, 800x600 (True Color), NT 4.0 SP5.

- [Linux] Vectra VL (266 MHz P2), 96 MB RAM. Red Hat Linux 6.0 (GNOME).

Comment 1

[Sean Su]

reassigning to Samir.  It's mac thang...

Comment 2

[Samir Gehani]

We considered putting a "Stop" button in place of the "Install" button and
hiding the "Go Back" button altogether once installation of the .xpis commences.
However, it is currently not possible to stop midway through a .xpi installation
(architectural constraint of calling the XPInstall shared lib synchronously).

So, we have two cosmetic options. I seek a vote.
1> Disable both buttons
2> Hide both buttons

I'm leaning towards option 1, which is the summary of this bug alludes to
anyways.

Comment 3

[Eli Goldberg]

Unfortunately, I don't have a meaningful opinion as to which is better, and defer
to sfraser.

Comment 4

[Samir Gehani]

Fixed: disable the buttons when installing now.

Comment 5

[Grace Bush]

this appears to be working on build 1999112308,
Eli, do you want to verify after me and mark?

Comment 6

[leger]

Updating component from Install Wizard to Installer

Comment 7

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/f963f6a58eb0
[fenix] Increased text contrast ratio of TextViews in 'Share tab' (https://github.com/mozilla-mobile/fenix/pull/18880)