1888005 - Update android nightly application-services version bump to new version a69ebea12384421435ff6b555573e04dc497dcdc from 2024-03-26 20:11:06

Status: RESOLVED FIXED

(Firefox for Android :: General, enhancement)

Description

[Update Bot]

This update covers 3 commits, including 2 new upstream commits I've never filed a bug on before. (They're the top 2.). Here are the overall diff statistics, and then the commit information.

---

mobile/android/android-components/plugins/dependencies/src/main/java/ApplicationServices.kt | 2 +-
mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

a69ebea12384421435ff6b555573e04dc497dcdc by Ben Dean-Kawamura

https://github.com/mozilla/application-services/commit/a69ebea12384421435ff6b555573e04dc497dcdc
Authored: 2024-03-22 17:21:47 -0400
Committed: 2024-03-26 20:11:06 +0000

Speedup ingestion times

Changed the ingestion code to prepare statements outside of any loops
rather than creating them on each iteration. Also, use tuples rather
than named arguments. This cuts ingestion time in half for the 2 record
types that dominate the total time:

ingest/ingest-amp-wikipedia
                        time:   [446.26 ms 446.85 ms 447.53 ms]
                        change: [-51.727% -51.566% -51.408%] (p = 0.00 < 0.05)
                        Performance has improved.

ingest/ingest-amp-mobile
                        time:   [240.08 ms 240.25 ms 240.48 ms]
                        change: [-49.921% -49.801% -49.672%] (p = 0.00 < 0.05)
                        Performance has improved.

Refactored the prepare and execute calls into their own struct. This
way it's easy to make sure that the arguments line up correctly with the
statement placeholders. I also think it simplifies things to remove the
specifics of each SQL statement from the general ingestion logic.

Files Modified:

• components/suggest/src/db.rs

---

ad2a484e77b60c57e980b55407c11fe98c511c81 by Ben Dean-Kawamura

https://github.com/mozilla/application-services/commit/ad2a484e77b60c57e980b55407c11fe98c511c81
Authored: 2024-03-26 14:39:54 -0400
Committed: 2024-03-26 19:48:00 +0000

Bug 1887071 - Clear out tokens/keys when starting an oauth flow

Files Modified:

• components/fxa-client/src/internal/oauth.rs
• components/fxa-client/src/internal/state_manager.rs

---

9003f77ada101822193cc2477b4e59b7a0de5603 by Charlie

https://github.com/mozilla/application-services/commit/9003f77ada101822193cc2477b4e59b7a0de5603
Authored: 2024-03-13 16:13:59 -0500
Committed: 2024-03-25 15:21:07 +0000

update Nimbus to write targeting attributes after each individual enrollment

Files Added:

• components/nimbus/src/stateful/targeting.rs

Files Modified:

• components/nimbus/src/enrollment.rs
• components/nimbus/src/stateful/enrollment.rs
• components/nimbus/src/stateful/evaluator.rs
• components/nimbus/src/stateful/mod.rs
• components/nimbus/src/stateful/nimbus_client.rs
• components/nimbus/src/stateless/cirrus_client.rs
• components/nimbus/src/targeting.rs
• components/nimbus/src/tests/stateful/test_enrollment.rs
• components/nimbus/src/tests/stateful/test_nimbus.rs
• components/nimbus/src/tests/test_enrollment.rs

---

Comment 2

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=6183c832621b3b43030f84a56a034506245766bd

Comment 3

[Update Bot]

Attachment: Bug 1888005 - Update android nightly application-services version bump to a69ebea12384421435ff6b555573e04dc497dcdc

Comment 4

[Update Bot]

All jobs completed, we found the following issues.

Needs Investigation (Other Failed Jobs):

• generate-profile-android-x86_64-shippable/opt
  • 1 of 1 failed on the same (retriggered) task (U6cVs4ztSsmelPzouwb9OQ)

These failures may mean that the library update succeeded; you'll need to review
them yourself and decide. If there are lint failures, you will need to fix them in
a follow-up patch. (Or ignore the patch I made, and recreate it yourself with
./mach vendor mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml.)

In either event, I have done all I can, so you will need to take it from here.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f83ae5ed87c
Update android nightly application-services version bump to a69ebea12384421435ff6b555573e04dc497dcdc r=dmeehan

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6f83ae5ed87c