1888054 - [wpt-sync] Sync PR 45339 - Fix ICE bad port test in WebRTC

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45339 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45339
Details from upstream follow.

Dominique Hazael-Massieux <[e-mail]> wrote:

Fix ICE bad port test in WebRTC

The test used onicestatechange instead of oniceconnectionstatechange. Also now runs on the full list of bad ports for completeness (thus requiring a long timeout)

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 45339 applied with additional changes from upstream: 0099557fb76dfb541bc926ca38793f4e2b0eecdb

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=eadbbb29edfc808f1d541ce4691b8cf005b68432

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 83 subtests

Status Summary

Firefox

OK : 1
PASS: 81
FAIL: 2

Chrome

OK : 1
PASS: 63
FAIL: 20

Safari

OK : 1
PASS: 63
FAIL: 20

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc/RTCPeerConnection-addTcpIceCandidate.html [wpt.fyi]
  • TCP candidate aimed at port 8001 accepted: FAIL (Chrome: FAIL, Safari: FAIL)
  • TCP addIceCandidate aimed at port 8001 accepted: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8ae9ea7c5f2
[wpt PR 45339] - Fix ICE bad port test in WebRTC, a=testonly

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a8ae9ea7c5f2