1888400 - Fix quad nine-patch with non-solid-color patterns

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Nicolas Silva [:nical]]

The quad nine-patch is hard-coded to emit color/image quads for all segments, I missed that in my initial attempt to support more patterns and weit appears we don't have a test case that covers this (for gradients).
It works only for color primitives since images and solid colors are handled by the same shader, so the broken code paths haven't landed yet.

Instead, the nine-patch path should produce image quads for the masked segments and render the source pattern directly for other segments.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1888400 - Rename add_segment into add_render_task. r=gw

And hoist the create_task condition out. This makes it easier to see what's going on.

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1888400 - Fix quad nine-patches for non-color primimitves. r=gw

The loop was submitting a single command in the command buffer, always using the textured quad shader which worked when the interior is a solid color but not for other patterns.
This patch goes over the nine-patch segments twice, first generating a segmented primitive for the interrior with the appropriate pattern shader, and then the corners with the textured shader.

The patch tries to stay in the spirit of the existing code. I'm not super fond of the result. If the pattern isn't opaque the nine-patch will batch poorly since the both the interrior and corner parts are batched using the same rect. Also I suspect we'll find that we need more flexibility if/when we implement borders using quads. By then we'll probably have a clearer idea of the best way to handle segments in general.

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1888400 - Add a test. r=gw

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9e0b8db1532
Rename add_segment into add_render_task. r=gw
https://hg.mozilla.org/integration/autoland/rev/0fd0f35dc653
Fix quad nine-patches for non-color primimitves. r=gw
https://hg.mozilla.org/integration/autoland/rev/b8e93a704beb
Add a test. r=gw

Comment 5

[Iulian Moraru]

Backed out for causing reftest failures on radial-size-1a.html.

• Push with failures

• Failure log

• Backout link

LATER EDIT: some Wrench build bustages appeared later. So far, they only happened on Android 11.0 Samsung A51 Arm7 opt and debug.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f6f515b10c4
Rename add_segment into add_render_task. r=gw
https://hg.mozilla.org/integration/autoland/rev/3fc7d72e1ea3
Fix quad nine-patches for non-color primimitves. r=gw
https://hg.mozilla.org/integration/autoland/rev/9f62b9886f80
Add a test. r=gw

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3f6f515b10c4
https://hg.mozilla.org/mozilla-central/rev/3fc7d72e1ea3
https://hg.mozilla.org/mozilla-central/rev/9f62b9886f80

Comment 8

[Mayank Bansal]

It may be worthwhile to test all the regressions from bug 1823579 (Many of the bugs i have filed are either from those bugs, or show similar symptoms)

Comment 9

[Natalia Csoregi [:nataliaCs]]

Backed out 6 changesets (bug 1889600, bug 1885571, bug 1888400, bug 1887837) for causing multiple regressions.

• backout: https://hg.mozilla.org/integration/autoland/rev/b79722547ccb00704f8a180b7910b8b3c6805f4e

Comment 10

[Mayank Bansal]

(In reply to Mayank Bansal from comment #8)

It may be worthwhile to test all the regressions from bug 1823579 (Many of the bugs i have filed are either from those bugs, or show similar symptoms)

For when this bug is being landed : Please test bug 1827648 as I could repro that.

Comment 11

[Master ? [:masterquestionable]]

    Worth notice:
    https://bugzilla.mozilla.org/show_bug.cgi?id=1890082#c3
    (regression details)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b777570e29b8
Rename add_segment into add_render_task. r=gw
https://hg.mozilla.org/integration/autoland/rev/c130f76ff541
Fix quad nine-patches for non-color primimitves. r=gw
https://hg.mozilla.org/integration/autoland/rev/f7d50e650bf1
Add a test. r=gw

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b777570e29b8
https://hg.mozilla.org/mozilla-central/rev/c130f76ff541
https://hg.mozilla.org/mozilla-central/rev/f7d50e650bf1