1888424 - [wpt-sync] Sync PR 45409 - Make Composited Animations Invalidate Paint Directly

Status: RESOLVED FIXED

(Core :: Web Painting, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45409 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45409
Details from upstream follow.

Claire Chambers <[e-mail]> wrote:

Make Composited Animations Invalidate Paint Directly

The previous system of relying on synthetic style diffs to produce paint invalidation proved too unwieldly, and created issues where animation changes in the pending animation update would cause crashes in certain situations.

This CL completely removes CompositablePaintAnimationChanged and replaces it with an extra hook in post style update scope. Any animations that are compositor pending or have been canceled have their corresponding layout objects invalidated.

Help requested:

• initial code review
• I can verify that my clip-path-animation-stress.html test works in other directories, but when I put it in css3/masking/ external/wpt/css/css-masking/clip-path/animation the promise test API I have used doesn't run. My knowledge of the test infrastructure is lacking in this respect so advice is welcome.

Bug: 1246826

Change-Id: Ib071d09b337ec786188aa5323dd4e6a95cfb962f
Reviewed-on: https://chromium-review.googlesource.com/5384914
WPT-Export-Revision: 2da11981bc45d6fd0f624d10366429ebb17aed32

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=44b7b62d36e1a71b8830e3e1bdfe27cd61285a39

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebf0214c1a94
[wpt PR 45409] - Make Composited Animations Invalidate Paint Directly, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ebf0214c1a94