1888451 - Setting custom SanitizeOnShutdown policy doesn't result in locked History Options Dropdown

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, defect, P3)

Description

[Pascal Reintjens]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

1. Created a policies.json file with the following contents:

{
	"policies": {		
		"SanitizeOnShutdown": {
			"Cache": true,
			"Cookies": true,			
			"Downloads": true,
			"FormData": true,
			"Sessions": true,			
			"OfflineApps": true,
			"Locked": true
		}
	}	
}

2. Subsequently, placed this file within the installation directory: C:\Program Files\Mozilla Firefox\distribution\policies.json
3. restarted the browser and went to Privacy & Security > History

Actual results:

The settings get applied and the dropdown changes to: Firefox will Use custom settings for history
But this dropdown is not locked and therefore the user can switch the dropdown to "Remember History" or "Never remeber history". When to user changes the dropdown, it gets then switched back when restarting Firefox again.

Expected results:

The dropdown should be locked / greyed out so that the user doesn't think that he could change this option even though he can't.

Comment 1

[Daniel Bodea [:danibodea]]

I can reproduce this issue in Windows 10 with Nightly v126.0a1, Beta v125.0 (RC), Release v124.0.2 and ESR v115.9.1esr.

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:mkaply, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1888451 - Disable history dropdown when SanitizeOnShutdown locks the pref. r?mstriemer

Comment 4

[agoloman]

Backed out for causing bc failures @browser_policy_sanitize_on_shutdown.js.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/63b552a161e4
https://hg.mozilla.org/integration/autoland/rev/78c6f2889749
Revert "Bug 1888451 - Disable history dropdown when SanitizeOnShutdown locks the pref. r=bvandersloot" for causing bc failures @browser_policy_sanitize_on_shutdown.js.

Comment 6

[BMO Github Automation]

Authored by https://github.com/mkaply
https://github.com/mozilla/enterprise-firefox/commit/fdf89abd7bd720b16607121e881e67aa745010f7
[enterprise-main] Bug 1888451 - Disable history dropdown when SanitizeOnShutdown locks the pref. r=bvandersloot

Authored by agoloman
https://github.com/mozilla/enterprise-firefox/commit/63b552a161e438928eb9bcbae1023fb4b37ee403
[enterprise-main] Revert "Bug 1888451 - Disable history dropdown when SanitizeOnShutdown locks the pref. r=bvandersloot" for causing bc failures @browser_policy_sanitize_on_shutdown.js.

Comment 7

[Mike Kaply [:mkaply]]

Looks like I clashed with the Settings redesign.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5518febc9504
https://hg.mozilla.org/integration/autoland/rev/944214e4dc1e
Disable history dropdown when SanitizeOnShutdown locks the pref. r=mstriemer,bvandersloot

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/944214e4dc1e

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fdf89abd7bd7
https://hg.mozilla.org/releases/mozilla-beta/rev/996e2a70d42d
Disable history dropdown when SanitizeOnShutdown locks the pref. r=bvandersloot