1888463 - Extra padding on the bottom border of a imageless tab hover preview

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Gif showing the issue

Found in

• Latest Nightly 126.0a1

Affected versions

• Latest Nightly 126.0a1

Tested platforms

• Affected platforms: MacOS 13, Windows 11, Ubuntu 22.04
• Unaffected platforms: none

Preconditions

• Set browser.tabs.cardPreview.enabled to true

Steps to reproduce

1. Open a few new tabs
2. Restart the browser
3. Hover with the mouse over a few tabs that don't have an image in the preview

Expected result

• The border of the preview is correctly displayed with no artifacts.

Actual result

• Extra padding is added to the bottom border for preview without images. It does fix itself once the tab is clicked though but restarting the browser again will make it reproduce again.

Regression range

• First bad: 2024-03-28-09-23-13
• Last good: 2024-03-27-21-44-48
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f8ac03b3c764017d5704deed413c8d35c99978fd&tochange=6109c9e63027ad132c8448ca4457d263284fc283
• Potentially regressed by: Not sure which of these bugs might have caused this (maybe bug 1878920) and I am unable to check in autoland yet using mozregression, I had to manually check for a regression. Will check deeper tomorrow or monday if mozregression allows it (does not allow to search on such fresh builds).

Comment 2

[Itiel]

Some extra info from the duplicate:
This is because tab-preview-thumbnail-container exists on the DOM when it shouldn't, possibly related to this code:
https://searchfox.org/mozilla-central/rev/f602853ba8d55ba157e2a74d9b571615f6ed97b8/browser/components/tabpreview/tabpreview.mjs#152

Comment 3

[Bogdan Maris, Desktop Test Engineering]

This was fixed by bug 1890397, thus closing it as fixed.