1888510 - [wpt-sync] Sync PR 45411 - Fix conversion test in CSSLengthInterpolationType::MaybeConvertInherit.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45411 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45411
Details from upstream follow.

L. David Baron <[e-mail]> wrote:

Fix conversion test in CSSLengthInterpolationType::MaybeConvertInherit.

This check for IsAuto was really checking whether the GetLength
succeeded; it is now possible for GetLength to succeed while setting the
length to auto.

The web-animations/responsive/width.html is only tangentially related,
since it was written when I thought this was really testing for 'auto'.
The existing failure in that test matches existing failures in other
tests in the same directory, on which it was modeled.

The change to
external/wpt/css/css-values/calc-size/animation/calc-size-width-interpolation.tentative.html
does test the fix.

I added tracking of the boolean in the InheritedLengthChecker despite
that I can't think of a case where it matters today. I think it's the
right thing given the function semantics, and not doing so could lead to
subtle bugs given future changes to LengthPropertyFunctions::GetLength.

(This was part of auditing uses of Length::IsAuto() to convert the
necessary ones to HasAuto().)

Bug: 313072
Change-Id: I5f7e5efe0d6f1b6ca598130ba50b06c65f3c721d

Reviewed-on: https://chromium-review.googlesource.com/5405916
WPT-Export-Revision: 19c9960593ce442f53bc45bcea8b1d98c763bb54

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd643d5b059a1434b93e028d43327d3e81f7daa0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 4 subtests

## Status Summary

### Firefox
`OK`  : 2
`PASS`: 2
`FAIL`: 888

### Chrome
`OK`  : 2
`PASS`: 491
`FAIL`: 399

### Safari
`OK`  : 2
`PASS`: 3
`FAIL`: 887

## Links
[GitHub PR Head](https://wpt.fyi/results/?sha=12296c1d7df48bf7bcbf85e2e060d5a1bba39ec2&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=12296c1d7df48bf7bcbf85e2e060d5a1bba39ec2&label=pr_base)

## Details

### Firefox-only Failures
* [/web-animations/responsive/width.html](https://wpt.live/web-animations/responsive/width.html) [[wpt.fyi](https://wpt.fyi/results/web-animations/responsive/width.html)]
  * width responsive to inherited changes from length: `FAIL`

(See attachment for full changes)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3c548c40dad
[wpt PR 45411] - Fix conversion test in CSSLengthInterpolationType::MaybeConvertInherit., a=testonly
https://hg.mozilla.org/integration/autoland/rev/1a2b8dc3db5a
[wpt PR 45411] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d3c548c40dad
https://hg.mozilla.org/mozilla-central/rev/1a2b8dc3db5a