Open Bug 1888516 Opened 2 years ago Updated 2 years ago

Optimize the invalidateActions() function call to not cause overlap of icons.

Categories

(Firefox for Android :: Toolbar, enhancement)

All
Android
enhancement

Tracking

()

People

(Reporter: skhan, Unassigned)

Details

Attachments

(1 file)

With the addition of translation icon, we have been seeing overlaps of reader mode icons and translate icons many a times.
Today with this PR https://phabricator.services.mozilla.com/D205105#inline-1137122, we have come up with more of a hacky solution which works.
But we need to revisit this and dig deep as to how we can improve the functionality to not cause this issue.

Steps to replicate, would be to

  1. make sure translation feature are enabled.
  2. Open a wikipedia page in a different language than your system language which causes translation icon to show up.
  3. Keep pressing links within and it ultimately causes the overlap.

Attaching the screenshot.

Attached image Overlap of page actions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: