Closed Bug 1888680 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 45430 - Revert "css-text: Fix an issue on justification with a bidi isolate control"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox126 fixed)

Status:
RESOLVED FIXED
Milestone:
126 Branch
Tracking Flags:
Tracking Status
firefox126 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45430 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45430
Details from upstream follow.

thefrog <thefrog@chromium.org> wrote:

Revert "css-text: Fix an issue on justification with a bidi isolate control"

This reverts commit aea8539fd737b4468aab83c14c656662b1322517.

Reason for revert: Causes consistent failure on msan builders for test
CachingWordShaperTest.SegmentEmojiSubdivisionFlags. More details in
crbug.com/331834503.

Original change's description:

css-text: Fix an issue on justification with a bidi isolate control

Do not reset is_after_expansion state by a default ignorable code
point, which includes bidi controls.

Bug: 331680200
Change-Id: I2c79ec467052861e9048b0b7575e8f29dc0570b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5401304
Commit-Queue: Koji Ishii \<kojii@chromium.org>
Auto-Submit: Kent Tamura \<tkent@chromium.org>
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280093}

Bug: 331680200
Change-Id: I8f2ff68ffa0a8d29f9d8d4fa827046bc84d3a366

Reviewed-on: https://chromium-review.googlesource.com/5407434
WPT-Export-Revision: 9cd59b16564b5feab06df1c92103c1cf78247a60

PR 45430 applied with additional changes from upstream: d281c718c65699764f30269e3a0243f80f2174c4
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56286ac491d2 [wpt PR 45430] - Revert "css-text: Fix an issue on justification with a bidi isolate control", a=testonly
Test result changes from PR not available.
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/56286ac491d2

Status: REOPENED → RESOLVED
Closed: 1 year ago → 1 year ago
status-firefox126: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.