1888772 - enable cpu runtime detection in bundled libvpx for OpenBSD/arm64

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[Landry Breuil (:gaston)]

on OpenBSD/arm64, libvpx fails to build because there's nothing for cpu runtime detection, and we hit the default codepath in https://searchfox.org/mozilla-central/source/media/libvpx/libvpx/vpx_ports/aarch64_cpudetect.c#182

we have a patch for the systemwide libvpx since a while in https://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/multimedia/libvpx/patches/patch-vpx_ports_aarch64_cpudetect_c?rev=1.1&content-type=text/x-cvsweb-markup and it was ported to firefox in https://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/www/mozilla-firefox/patches/patch-media_libvpx_libvpx_vpx_ports_aarch64_cpudetect_c?rev=1.2&content-type=text/x-cvsweb-markup

since upstream libvpx is chromium and generally doesnt welcome non-tier1-supporting patches, could this patch (or a variation of it) be added to the patches that updatebot applies ?

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1888772 - Import ARM-CPU-runtime-detection-on-OpenBSD patch

This patch imports the fix to build ARM CPU runtime detection code on
OpenBSD [1] to our code base.

[1] https://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/multimedia/libvpx/patches/patch-vpx_ports_aarch64_cpudetect_c?rev=1.1&content-type=text/x-cvsweb-markup

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1888772 - Add arm-cpu-runtime-detection patch to moz.yaml

Depends on D206408

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1888772 - Apply ARM-CPU-runtime-detection patch

This patch runs the command below

./mach vendor media/libvpx/moz.yaml --patch-mode=only --ignore-modified

with arm_cpu_runtime_detection_code_on_openbsd.patch in moz.yaml's
patches list only (other patches are temporarily removed during the
process).

Depends on D206409

Comment 4

[C.M.Chang[:chunmin]]

Sure, I've imported the patch to our code base and I am going to test it on our CI: https://treeherder.mozilla.org/jobs?repo=try&revision=0ef36e4bf3479017890d7b51dedd5db71a415355

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/112d7c3a8432
Import ARM-CPU-runtime-detection-on-OpenBSD patch r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/26ac68728a9c
Add arm-cpu-runtime-detection patch to moz.yaml r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/6d481aee635e
Apply ARM-CPU-runtime-detection patch r=media-playback-reviewers,padenot

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/112d7c3a8432
https://hg.mozilla.org/mozilla-central/rev/26ac68728a9c
https://hg.mozilla.org/mozilla-central/rev/6d481aee635e

Comment 7

[Landry Breuil (:gaston)]

thanks :chunmin!