1888869 - [wpt-sync] Sync PR 45441 - Reland "css-text: Fix an issue on justification with a bidi isolate control"

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45441 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45441
Details from upstream follow.

Kent Tamura <[e-mail]> wrote:

Reland "css-text: Fix an issue on justification with a bidi isolate control"

This is a reland of commit aea8539fd737b4468aab83c14c656662b1322517

A change from the original commit:

• Updated TextRun::NormalizedUTF16().
  Because the coverage of TreatAsZeroWidthSpaceInComplexScript() was
  expanded by the original commit, NormalizedUTF16() could replace a
  non-BMP character with a BMP character. It caused an access to
  uninitialized area in a StringBuffer. The function doesn't replace
  non-BMP characters in this CL.

Original change's description:

css-text: Fix an issue on justification with a bidi isolate control

Do not reset is_after_expansion state by a default ignorable code
point, which includes bidi controls.

Bug: 331680200
Change-Id: I2c79ec467052861e9048b0b7575e8f29dc0570b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5401304
Commit-Queue: Koji Ishii \<[e-mail]>
Auto-Submit: Kent Tamura \<[e-mail]>
Reviewed-by: Koji Ishii \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1280093}

Bug: 331680200, 331834503
Change-Id: I5c76573203b99045fe7350b87f091ff13b2b5a67

Reviewed-on: https://chromium-review.googlesource.com/5400825
WPT-Export-Revision: a7fc01e77a75ef7cac94621a3a16054259e2f76d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b588d51c4161f28a49d84fc6a1b4742dc66ccf10

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/267a33f6b950
[wpt PR 45441] - Reland "css-text: Fix an issue on justification with a bidi isolate control", a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/267a33f6b950