Closed Bug 1888879 Opened 2 months ago Closed 2 months ago

Arrows on separator between task list and task description point in the wrong direction (left/right instead of up/down)

Categories

(Calendar :: Calendar Frontend, defect)

Thunderbird 115
defect

Tracking

(thunderbird_esr115 fixed, thunderbird125 fixed)

RESOLVED FIXED
126 Branch
Tracking Status
thunderbird_esr115 --- fixed
thunderbird125 --- fixed

People

(Reporter: mozilla, Assigned: Paenglab)

References

Details

(Whiteboard: [TM 115.10.+])

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

  1. Upgraded to 115.7.0
  2. Worked normally with it for a couple of hours

Actual results:

The up/down arrow on the horizontal separation line between the task list and the description of one task changed into a left/right arrow. That left-right arrow can no longer be used to change the size of the task description pane below.

For a moment, the scrollbar to the right of the task description also disappeared. However, I could make that one re-appear by closing the tasks tab, restarting thunderbird, and then adding the tasks tab again. However, this operation did not restore the function of the separation bar between list and description

Expected results:

The arrows on the separation between task list and task description should stay up/down

Summary: Shortly after upgrading to 115.7.0, tasks display gets messed up → Arrows on separator between task list and task description point in the wrong direction (left/right instead of up/down)

Just a correction to my initial description: the problem actually happens right from the beginning (as soon as "up"grading to 115.7.0), so it's not an issue of the profile becoming corrupted, rather it's just a bad definition in the 115.7.0 layout.

Adding orient="vertical" to the definition of the calendar-task-view-splitter in chrome/messenger/content/messenger/messenger.xhtml in /usr/share/thunderbird/omni.ja fixes the display of the arrow, but after that it is still non-functional (i.e. you can't actually drag it up or down)

Using the Developer Toolbox, I see that dragging the calendar-task-view-splitter splitter does indeed change the height="" and style="... height: ..." values of the calendar-task-tree above the splitter, but the calendar-task-tree's displayed dimensions doesn't change.

Manually changing the height using Developer Toolbox does nothing to the display either.

However, setting a max-height on the calendar-task-tree does have an effect on the display.

Calendar is a better product choice ;)

Component: Untriaged → Calendar Frontend
Product: Thunderbird → Calendar
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Actually there's more to it than just the "orient" attribute.

Please see my comment 2: adding the orient attribute to the calendar-task-view-splitter fixes the visual appearance of the arrow. However even after fixing that, the arrow is still non-functional: "height" style of pane above is adjusted, but somehow that pane disregards "height". It seems to only react to "max-height" and "min-height" instead.

We normally fix one issue per bug. Best would be you file a new bug for the splitter movement.

Target Milestone: --- → 126 Branch

Pushed by martin@humanoids.be:
https://hg.mozilla.org/comm-central/rev/0fa9bddedc63
Add the orient attribute to the calendar-task-view-splitter. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED

Comment on attachment 9394930 [details]
Bug 1888879 - Add the orient attribute to the calendar-task-view-splitter. r=#thunderbird-reviewers

[Approval Request Comment]
User impact if declined: wrong direction of arrow cursor
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9394930 - Flags: approval-comm-esr115?
Attachment #9394930 - Flags: approval-comm-beta?

Comment on attachment 9394930 [details]
Bug 1888879 - Add the orient attribute to the calendar-task-view-splitter. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9394930 - Flags: approval-comm-beta? → approval-comm-beta+
Whiteboard: [TM 115.10.+]

Comment on attachment 9394930 [details]
Bug 1888879 - Add the orient attribute to the calendar-task-view-splitter. r=#thunderbird-reviewers

[Triage Comment]
We will let this ride the train to 128

Attachment #9394930 - Flags: approval-comm-esr115? → approval-comm-esr115-

(In reply to Wayne Mery (:wsmwk) from comment #12)

Comment on attachment 9394930 [details]
Bug 1888879 - Add the orient attribute to the calendar-task-view-splitter. r=#thunderbird-reviewers

[Triage Comment]
We will let this ride the train to 128

Yes, I did notice that although functionality (bug 1889562) is fixed in 115.10.1, the visual appearance (this bug) is still broken.

Ok, with this, it was indeed more important to get the functionality fixed.

Depends on: 1889562

Comment on attachment 9394930 [details]
Bug 1888879 - Add the orient attribute to the calendar-task-view-splitter. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

I did not notice this was connected to another (fixed) bug. So let's take it.

Attachment #9394930 - Flags: approval-comm-esr115- → approval-comm-esr115+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: