1888879 - Arrows on separator between task list and task description point in the wrong direction (left/right instead of up/down)

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Alain Knaff]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

1. Upgraded to 115.7.0
2. Worked normally with it for a couple of hours

Actual results:

The up/down arrow on the horizontal separation line between the task list and the description of one task changed into a left/right arrow. That left-right arrow can no longer be used to change the size of the task description pane below.

For a moment, the scrollbar to the right of the task description also disappeared. However, I could make that one re-appear by closing the tasks tab, restarting thunderbird, and then adding the tasks tab again. However, this operation did not restore the function of the separation bar between list and description

Expected results:

The arrows on the separation between task list and task description should stay up/down

Comment 1

[Alain Knaff]

Just a correction to my initial description: the problem actually happens right from the beginning (as soon as "up"grading to 115.7.0), so it's not an issue of the profile becoming corrupted, rather it's just a bad definition in the 115.7.0 layout.

Comment 2

[Alain Knaff]

Adding orient="vertical" to the definition of the calendar-task-view-splitter in chrome/messenger/content/messenger/messenger.xhtml in /usr/share/thunderbird/omni.ja fixes the display of the arrow, but after that it is still non-functional (i.e. you can't actually drag it up or down)

Comment 3

[Alain Knaff]

Using the Developer Toolbox, I see that dragging the calendar-task-view-splitter splitter does indeed change the height="" and style="... height: ..." values of the calendar-task-tree above the splitter, but the calendar-task-tree's displayed dimensions doesn't change.

Manually changing the height using Developer Toolbox does nothing to the display either.

However, setting a max-height on the calendar-task-tree does have an effect on the display.

Comment 4

[Wayne Mery (:wsmwk)]

Calendar is a better product choice ;)

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Bug 1888879 - Add the orient attribute to the calendar-task-view-splitter. r=#thunderbird-reviewers

Comment 6

[Alain Knaff]

Actually there's more to it than just the "orient" attribute.

Please see my comment 2: adding the orient attribute to the calendar-task-view-splitter fixes the visual appearance of the arrow. However even after fixing that, the arrow is still non-functional: "height" style of pane above is adjusted, but somehow that pane disregards "height". It seems to only react to "max-height" and "min-height" instead.

Comment 7

[Richard Marti (:Paenglab)]

We normally fix one issue per bug. Best would be you file a new bug for the splitter movement.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0fa9bddedc63
Add the orient attribute to the calendar-task-view-splitter. r=aleca

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 9394930 [details]
Bug 1888879 - Add the orient attribute to the calendar-task-view-splitter. r=#thunderbird-reviewers

[Approval Request Comment]
User impact if declined: wrong direction of arrow cursor
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9394930 [details]
Bug 1888879 - Add the orient attribute to the calendar-task-view-splitter. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 125.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/7744ae5c7592

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9394930 [details]
Bug 1888879 - Add the orient attribute to the calendar-task-view-splitter. r=#thunderbird-reviewers

[Triage Comment]
We will let this ride the train to 128

Comment 13

[Alain Knaff]

(In reply to Wayne Mery (:wsmwk) from comment #12)

Comment on attachment 9394930 [details]
Bug 1888879 - Add the orient attribute to the calendar-task-view-splitter. r=#thunderbird-reviewers

[Triage Comment]
We will let this ride the train to 128

Yes, I did notice that although functionality (bug 1889562) is fixed in 115.10.1, the visual appearance (this bug) is still broken.

Ok, with this, it was indeed more important to get the functionality fixed.

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9394930 [details]
Bug 1888879 - Add the orient attribute to the calendar-task-view-splitter. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

I did not notice this was connected to another (fixed) bug. So let's take it.

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 115.11.0:
https://hg.mozilla.org/releases/comm-esr115/rev/422a2fec3023