1888939 - Refactor the output of PubSubCrashQueue.__iter__

Status: UNCONFIRMED

(Socorro :: Backend, task)

Description

[Daniel Thorn [:relud]]

the pubsub crash queue __iter__ method has a return type that is perhaps unnecessarily complex for what it returns. it used to be useful, but it could probably be simplified it now that it isn't needed.

https://github.com/mozilla-services/socorro/blob/a17ab34e66fa0e41304ceb77636aad435cf102c1/socorro/external/pubsub/crashqueue.py#L176-L183

    def __iter__(self):
        """Return iterator over crash ids from Pub/Sub.

        Each returned crash is a ``(crash_id, {kwargs})`` tuple with
        ``finished_func`` as the only key in ``kwargs``. The caller should call
        ``finished_func`` when it's done processing the crash.

        """

from :willkg in https://github.com/mozilla-services/socorro/pull/6554#discussion_r1532813328

This is a remnant of how the processor did stuff years ago. We could probably refactor this curiosity out if we cared.

This should wait until after the GCP migration in bug 1687802 so that support for sqs can be dropped instead of also refactoring that.

status is UNCONFIRMED because there has not yet been a decision to actually do this.