1888982 - Make sure cocoa trees use the correct color.

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Bug 1888862 changed menuhover, but also the SelectedItem color. As per Markus' comment that might not be quite correct:

mstange: Why wash out SelectedItem? Won't this change the color of the selected tree item? That color was accurate before (compare the tree view in the library window with the tree view in the Activity Monitor app).

emilio: Hmm, yeah, you're right... This also affects stuff like the urlbar dropdown, but maybe that should not use SelectedItem necessarily... I thought that <tree> used a different color but apparently we use SelectedItem when focused: https://searchfox.org/mozilla-central/rev/10f46c9c638e0e5935ed9fa12aadc9d0d4e71ade/toolkit/themes/shared/tree.css#49,53

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1888862

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1888982 - Improve on bug 1888862. r=#mac-reviewers,mstange

• Only wash out the color when reduced transparency isn't requested
  (this matches native menus).
• Don't wash out SelectedItem (so that native trees etc aren't affected
  by the change).
• Match the color a bit better on dark mode.

Comment 3

[Donal Meehan [:dmeehan]]

:emilio the Soft Code Freeze starts on 2024-04-18 ahead of next week's merge to beta.
Just a reminder if you want to get this patch reviewed/landed before then

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Well I want but it's not up to me to review. I think the patch is low risk tho.

Comment 5

[Donal Meehan [:dmeehan]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

Well I want but it's not up to me to review. I think the patch is low risk tho.

Sorry, I mean do you need to get a different reviewer maybe?
Though there is still the rest of the week for it be reviewed

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8481a4aeea5
Improve on bug 1888862. r=mstange,mac-reviewers

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c8481a4aeea5